From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EDAFC433E6 for ; Wed, 22 Jul 2020 14:14:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FD3220729 for ; Wed, 22 Jul 2020 14:14:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732367AbgGVOO4 (ORCPT ); Wed, 22 Jul 2020 10:14:56 -0400 Received: from 8bytes.org ([81.169.241.247]:58728 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726003AbgGVOO4 (ORCPT ); Wed, 22 Jul 2020 10:14:56 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 204A0367; Wed, 22 Jul 2020 16:14:55 +0200 (CEST) Date: Wed, 22 Jul 2020 16:14:53 +0200 From: Joerg Roedel To: Wei Yongjun Cc: Hulk Robot , Eric Auger , Tom Murphy , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] iommu: Make some functions static Message-ID: <20200722141453.GL27672@8bytes.org> References: <20200713142542.50294-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200713142542.50294-1-weiyongjun1@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 13, 2020 at 10:25:42PM +0800, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/iommu/iommu.c:386:5: warning: > symbol 'iommu_insert_resv_region' was not declared. Should it be static? > drivers/iommu/iommu.c:2182:5: warning: > symbol '__iommu_map' was not declared. Should it be static? > > Those functions are not used outside of iommu.c, so mark them static. > > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/iommu/iommu.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks.