From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E57FC433E0 for ; Wed, 22 Jul 2020 22:33:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 544D92071A for ; Wed, 22 Jul 2020 22:33:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="M+VGBvQ+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732647AbgGVWdQ (ORCPT ); Wed, 22 Jul 2020 18:33:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726462AbgGVWdP (ORCPT ); Wed, 22 Jul 2020 18:33:15 -0400 Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 018DCC0619E1 for ; Wed, 22 Jul 2020 15:33:15 -0700 (PDT) Received: by mail-qt1-x843.google.com with SMTP id s23so3062604qtq.12 for ; Wed, 22 Jul 2020 15:33:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FNTzG6qcBQuW0UnSYe8/jDfHi5XObGtNTg45FW0KfjY=; b=M+VGBvQ+eQKQBCSLRfLaL/v6FZSuwRdtyTJX6r07YtUqLEva+Fz5S4iJyShRBpQ119 bcDKHcMIoRzgHSuqq0/fMI96YHvIv+USJdZ5Z6+uZY9nQhSww6xl0ywoebu+4WX87wgk FF74hwwPU7XWFybe3w/4/PoWIoFlevi/87tc6OYP+b/KplY9Ui4oHj/etquSuVuLtS7S PQgWA9ASEwCJbPzsByGq2exdZIQcyh7VpC6bICadwajduRf+C4LaAYeu3xjIt2Vtr2D5 8m3ZKcpYylNX3Iuhze4CR60MHFC0Sz8yAyDmL+CS9XASuzDeI+sEqvhr2rXkaOMQdaJ3 omyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FNTzG6qcBQuW0UnSYe8/jDfHi5XObGtNTg45FW0KfjY=; b=Vn7AMURfQpxB35cUgfIXA91I/0pPud/7eVk8Ui6DokWGnEhHFB7Z05HsPz1n4DOU4l wGCEKwqf4uxWkji05/B5RMDB8pxQPZ0FLzutOsDeOw1cPR1GGi7tuEazkiQl42K+Lzld lrWTmwcCt/FaviC5dc9T+UxCBMU7ziJ+yfsmdmjwdLfPr+dj9WVM3WML7SY/YCLpFKZI Wdq0utNwuO0ZbqeLkaj2sQGX2clR08b4GqDcJdmqSKqgTla+RaG6LyFw8qYDV1JzFsJ0 xljN6UwhTibuYOhf9Dsov+qMt4S26/PYpHWUJoZVGchcjuf4A+KkiB/pmvs+FCiKRoUJ YKlg== X-Gm-Message-State: AOAM5301I0bs7xNP+N0mceIbzoZMXXHN5v29wBLvaxXjDXGVb586cfbV LF/6dCG/DbJCPlypc9zCBVGVWA== X-Google-Smtp-Source: ABdhPJxiKbn56anOP6nT+bAbNNtR/OqTNAMF/G7Mw2zuA7Od619cKlMkiA82MbBqicSsEqw9RJOhMA== X-Received: by 2002:ac8:7454:: with SMTP id h20mr1587073qtr.84.1595457194224; Wed, 22 Jul 2020 15:33:14 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id x36sm990975qtk.36.2020.07.22.15.33.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2020 15:33:13 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1jyNIV-00E6RQ-L9; Wed, 22 Jul 2020 19:33:11 -0300 Date: Wed, 22 Jul 2020 19:33:11 -0300 From: Jason Gunthorpe To: Alexander Lobakin Cc: "David S. Miller" , Jakub Kicinski , Igor Russkikh , Michal Kalderon , Ariel Elior , Denis Bolotin , Doug Ledford , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , KP Singh , GR-everest-linux-l2@marvell.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 net-next 01/15] qed: reformat "qed_chain.h" a bit Message-ID: <20200722223311.GK25301@ziepe.ca> References: <20200722221045.5436-1-alobakin@marvell.com> <20200722221045.5436-2-alobakin@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200722221045.5436-2-alobakin@marvell.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 23, 2020 at 01:10:31AM +0300, Alexander Lobakin wrote: > Reformat structs and macros definitions a bit prior to making functional > changes. > > Signed-off-by: Alexander Lobakin > Signed-off-by: Igor Russkikh > Signed-off-by: Michal Kalderon > include/linux/qed/qed_chain.h | 126 ++++++++++++++++++---------------- > 1 file changed, 66 insertions(+), 60 deletions(-) > > diff --git a/include/linux/qed/qed_chain.h b/include/linux/qed/qed_chain.h > index 7071dc92b4e2..087073517c09 100644 > +++ b/include/linux/qed/qed_chain.h > @@ -26,9 +26,9 @@ enum qed_chain_mode { > }; > > enum qed_chain_use_mode { > - QED_CHAIN_USE_TO_PRODUCE, /* Chain starts empty */ > - QED_CHAIN_USE_TO_CONSUME, /* Chain starts full */ > - QED_CHAIN_USE_TO_CONSUME_PRODUCE, /* Chain starts empty */ > + QED_CHAIN_USE_TO_PRODUCE, /* Chain starts empty */ > + QED_CHAIN_USE_TO_CONSUME, /* Chain starts full */ > + QED_CHAIN_USE_TO_CONSUME_PRODUCE, /* Chain starts empty */ > }; > > enum qed_chain_cnt_type { > @@ -40,84 +40,86 @@ enum qed_chain_cnt_type { > }; > > struct qed_chain_next { > - struct regpair next_phys; > - void *next_virt; > + struct regpair next_phys; > + void *next_virt; > }; I'm surprised this is considered an improvement?? I've been encouring people to go the other way, maintaining vertical alignment is harmful to backporting.. Jason