From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92645C433DF for ; Thu, 23 Jul 2020 01:00:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70C862086A for ; Thu, 23 Jul 2020 01:00:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733262AbgGWBA5 (ORCPT ); Wed, 22 Jul 2020 21:00:57 -0400 Received: from netrider.rowland.org ([192.131.102.5]:33053 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1728607AbgGWBA4 (ORCPT ); Wed, 22 Jul 2020 21:00:56 -0400 Received: (qmail 1334189 invoked by uid 1000); 22 Jul 2020 21:00:55 -0400 Date: Wed, 22 Jul 2020 21:00:55 -0400 From: Alan Stern To: Evgeny Novikov Cc: Felipe Balbi , Greg Kroah-Hartman , Benjamin Herrenschmidt , Kees Cook , Arnd Bergmann , Corentin Labbe , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "ldv-project@linuxtesting.org" Subject: Re: [PATCH] usb: gadget: net2280: fix memory leak on probe error handling paths Message-ID: <20200723010055.GA1333715@rowland.harvard.edu> References: <20200721201558.20069-1-novikov@ispras.ru> <20200722141741.GA1310843@rowland.harvard.edu> <2097231595446720@mail.yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2097231595446720@mail.yandex.ru> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 22, 2020 at 10:56:09PM +0300, Evgeny Novikov wrote: > Hi Alan, > > I have neither an appropriate hardware nor an experience to deal with > issues that you mentioned. Our framework does not allow to detect them > as well at the moment. At last, it seems that rather many drivers can > suffer from these issues. So, it would be much better if somebody else > will suggest necessary fixes and test them carefully. Heh... Working from home, I no longer have access to the appropriate hardware either. But at least I do have the necessary experience. :-) > BTW, you have already discussed the race within net2280_remove() with > my colleague about 3 years ago. But you did not achieve a consensus at > that time and no fixes were made after all. I don't recall that. Do you have a pointer to the email thread in the archives? > Anyway, one can consider both issues independently on the one fixed by > the patch. Yes. I'll write and submit a series of patches. Alan Stern