From: Paul Cercueil <paul@crapouillou.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: od@zcrc.me, 周琰杰 <zhouyanjie@wanyeetech.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
"Paul Cercueil" <paul@crapouillou.net>,
"H . Nikolaus Schaller" <hns@goldelico.com>
Subject: [PATCH RESEND] memory: jz4780_nemc: Only request IO memory the driver will use
Date: Thu, 23 Jul 2020 11:04:14 +0200 [thread overview]
Message-ID: <20200723090414.5824-1-paul@crapouillou.net> (raw)
The driver only uses the registers up to offset 0x54. Since the EFUSE
registers are in the middle of the NEMC registers, we only request
the registers we will use for now - that way the EFUSE driver can
probe too.
Tested-by: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
Notes:
Thomas:
drivers/memory/ has no dedicated maintainer, so sending this
patch upstream is like sending a bottle to the sea. Since it
touches a driver for a Ingenic SoC, if Greg doesn't take it
(I don't blame him - he's a busy man), could you take it in
your tree?
Thanks,
-Paul
drivers/memory/jz4780-nemc.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/memory/jz4780-nemc.c b/drivers/memory/jz4780-nemc.c
index b232ed279fc3..647267ea8c63 100644
--- a/drivers/memory/jz4780-nemc.c
+++ b/drivers/memory/jz4780-nemc.c
@@ -8,6 +8,7 @@
#include <linux/clk.h>
#include <linux/init.h>
+#include <linux/io.h>
#include <linux/math64.h>
#include <linux/of.h>
#include <linux/of_address.h>
@@ -288,7 +289,19 @@ static int jz4780_nemc_probe(struct platform_device *pdev)
nemc->dev = dev;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- nemc->base = devm_ioremap_resource(dev, res);
+
+ /*
+ * The driver only uses the registers up to offset 0x54. Since the EFUSE
+ * registers are in the middle of the NEMC registers, we only request
+ * the registers we will use for now - that way the EFUSE driver can
+ * probe too.
+ */
+ if (!devm_request_mem_region(dev, res->start, 0x54, dev_name(dev))) {
+ dev_err(dev, "unable to request I/O memory region\n");
+ return -EBUSY;
+ }
+
+ nemc->base = devm_ioremap(dev, res->start, resource_size(res));
if (IS_ERR(nemc->base)) {
dev_err(dev, "failed to get I/O memory\n");
return PTR_ERR(nemc->base);
--
2.27.0
next reply other threads:[~2020-07-23 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 9:04 Paul Cercueil [this message]
2020-07-25 12:40 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723090414.5824-1-paul@crapouillou.net \
--to=paul@crapouillou.net \
--cc=gregkh@linuxfoundation.org \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=od@zcrc.me \
--cc=tsbogend@alpha.franken.de \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®