From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8B36C433E5 for ; Fri, 24 Jul 2020 11:48:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC9AA2073E for ; Fri, 24 Jul 2020 11:48:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726704AbgGXLsG (ORCPT ); Fri, 24 Jul 2020 07:48:06 -0400 Received: from elvis.franken.de ([193.175.24.41]:47133 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726317AbgGXLsG (ORCPT ); Fri, 24 Jul 2020 07:48:06 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jywBI-0003GQ-01; Fri, 24 Jul 2020 13:48:04 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id D1AB0C09A9; Fri, 24 Jul 2020 13:09:48 +0200 (CEST) Date: Fri, 24 Jul 2020 13:09:48 +0200 From: Thomas Bogendoerfer To: =?iso-8859-1?Q?=C1lvaro_Fern=E1ndez?= Rojas Cc: f.fainelli@gmail.com, jonas.gorski@gmail.com, bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: BCM63xx: improve CFE version detection Message-ID: <20200724110948.GB17183@alpha.franken.de> References: <20200608092835.3377581-1-noltari@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200608092835.3377581-1-noltari@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 08, 2020 at 11:28:35AM +0200, Álvaro Fernández Rojas wrote: > There are some CFE variants that start with 'cfe-vd' instead of 'cfe-v', such > as the one used in the Huawei HG556a: "cfe-vd081.5003". In this case, the CFE > version is stored as is (string vs number bytes). > > Some newer devices have an additional version number, such as the Comtrend > VR-3032u: "1.0.38-112.118-11". > > Finally, print the string as is if the version doesn't start with "cfe-v" or > "cfe-vd", but starts with "cfe-". > > Signed-off-by: Álvaro Fernández Rojas > --- > arch/mips/bcm63xx/boards/board_bcm963xx.c | 22 ++++++++++++++++++---- > 1 file changed, 18 insertions(+), 4 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]