From: Amelie Delaunay <amelie.delaunay@st.com>
To: Minas Harutyunyan <hminas@synopsys.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>
Cc: <linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
Fabrice Gasnier <fabrice.gasnier@st.com>,
Amelie Delaunay <amelie.delaunay@st.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: [PATCH 4/4] usb: dwc2: fix error path with missing dwc2_drd_exit
Date: Fri, 24 Jul 2020 14:37:48 +0200 [thread overview]
Message-ID: <20200724123748.25369-5-amelie.delaunay@st.com> (raw)
In-Reply-To: <20200724123748.25369-1-amelie.delaunay@st.com>
In case of failure, role switch has to be unregistered. It is done by
dwc2_drd_exit.
Fixes: bc0f0d4a5853 ("usb: dwc2: override PHY input signals with usb role switch support")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
drivers/usb/dwc2/platform.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
index 68b56b43a45e..f4a0371c3e89 100644
--- a/drivers/usb/dwc2/platform.c
+++ b/drivers/usb/dwc2/platform.c
@@ -600,6 +600,8 @@ static int dwc2_driver_probe(struct platform_device *dev)
return 0;
error_init:
+ dwc2_drd_exit(hsotg);
+
if (hsotg->params.activate_stm_id_vb_detection)
regulator_disable(hsotg->usb33d);
error:
--
2.17.1
next prev parent reply other threads:[~2020-07-24 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 12:37 [PATCH 0/4] Fix DWC2 USB role switch support Amelie Delaunay
2020-07-24 12:37 ` [PATCH 1/4] dt-bindings: usb: dwc2: add optional usb-role-switch property Amelie Delaunay
2020-07-24 12:37 ` [PATCH 2/4] usb: dwc2: fix build issue when config is USB_DWC2_HOST only Amelie Delaunay
2020-07-24 12:37 ` [PATCH 3/4] usb: dwc2: drd: fix sleeping while spinlock atomic context Amelie Delaunay
2020-07-24 12:37 ` Amelie Delaunay [this message]
2020-07-27 9:39 ` [PATCH 0/4] Fix DWC2 USB role switch support Amelie DELAUNAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724123748.25369-5-amelie.delaunay@st.com \
--to=amelie.delaunay@st.com \
--cc=alexandre.torgue@st.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®