From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16B09C433E1 for ; Fri, 24 Jul 2020 14:30:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E50DD2063A for ; Fri, 24 Jul 2020 14:30:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LSCgymqc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726977AbgGXOa0 (ORCPT ); Fri, 24 Jul 2020 10:30:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726858AbgGXOaZ (ORCPT ); Fri, 24 Jul 2020 10:30:25 -0400 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A98ADC0619D3; Fri, 24 Jul 2020 07:30:25 -0700 (PDT) Received: by mail-qk1-x742.google.com with SMTP id j187so8718772qke.11; Fri, 24 Jul 2020 07:30:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0doYQZ5KxAI0epYHGnX1pY85PpBpa6FQXw9KGp32jgE=; b=LSCgymqc23a7u8vGj3ljfoI1PZJMaYtkE7yqqQ+OCssLoh1nS1vOJMLcD8L/F48j4f FtTGxSON+/y1bHXvduhGAJ0DMGz62kCmajpHJM64C/6x8Co2LDx1YAybIuanYVMX1O83 O21zAvfXtVHHfJmoKaq8unw740IYMTDbnbxn2alMQ/XUzd2zBaJOq0Y5oyzp6RNXNkez Va9Jvo3i7wTKzgpGQZafRP+QSUsgdrlwz6Ebse5duXww5Ci8+44xD9g5s5Uv4h9tZq1L +py/6CsNgO+lbxUpsgzAUCCKnof+rh/kq+m7hKo/fHGM2FsSF2rYaO6DqCiHvIpt4OVZ BRuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:date:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=0doYQZ5KxAI0epYHGnX1pY85PpBpa6FQXw9KGp32jgE=; b=c7q9IK60QhmI+ngs2LkouPClct791zJQVNkvTTgJ/iSi9HwsZMP7EFJffuTZR2ZCaz in/fCvnJST95P7jrwbP4el2VG88k4ouhx2kR2ms76QHs3H5ItLkyFrV/TFc5PXWrvxFQ ROe649Kcjleh82NSTOLFlczjIJpPqhbvXE64526mca2dWxAtAE/xXTuYjYIFL0inbW4O HPSiWUB6jgJhBe95mwvZl7REwvW6GLx3bOLSlL5C5q9cVbcLsIxSXBCVe3XIfaYCYfht oU7H7p5ywybbnxOONIjTG1ijVfDJ/Ci978/BCqMNUCQ53WOLh2DtSw+6f3spslYDVlN9 izwg== X-Gm-Message-State: AOAM533GjB6JSIk3VmVopmMwWTzmz82mXVwMCg6VhLMHqnLRksHe8k+b CwqPjzDwJRkQDml+tKlroqU= X-Google-Smtp-Source: ABdhPJycpsyk8cS1ebXw2OYgrfVPpRHkjnq6ng5g57Pf/jCGvIpcIrVGARtXuqyL+Etpg52cwm2ESQ== X-Received: by 2002:ae9:f002:: with SMTP id l2mr11185843qkg.437.1595601024671; Fri, 24 Jul 2020 07:30:24 -0700 (PDT) Received: from rani.riverdale.lan ([2001:470:1f07:5f3::b55f]) by smtp.gmail.com with ESMTPSA id u42sm1697045qtu.48.2020.07.24.07.30.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 07:30:24 -0700 (PDT) From: Arvind Sankar X-Google-Original-From: Arvind Sankar Date: Fri, 24 Jul 2020 10:30:22 -0400 To: Sedat Dilek Cc: Nick Terrell , Borislav Petkov , Thomas Gleixner , linux-kernel@vger.kernel.org, Chris Mason , linux-kbuild@vger.kernel.org, x86@kernel.org, gregkh@linuxfoundation.org, Petr Malat , Kees Cook , Kernel Team , Adam Borowski , Patrick Williams , rmikey@fb.com, mingo@kernel.org, Patrick Williams , Norbert Lange , Andrew Morton , Alex Xu , Arvind Sankar , Nick Terrell Subject: Re: [PATCH v8 6/7] x86: Add support for ZSTD compressed kernel Message-ID: <20200724143022.GA601509@rani.riverdale.lan> References: <20200723192801.351114-1-nickrterrell@gmail.com> <20200723192801.351114-7-nickrterrell@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 24, 2020 at 02:50:34AM +0200, Sedat Dilek wrote: > On Thu, Jul 23, 2020 at 9:30 PM Nick Terrell wrote: > > > > From: Nick Terrell > > > > * Add support for zstd compressed kernel > > * Define __DISABLE_EXPORTS in misc.c > > * Bump the heap size for zstd. > > * Update the documentation. > > > > Integrates the ZSTD decompression code to the x86 pre-boot code. > > > > Zstandard requires slightly more memory during the kernel decompression > > on x86 (192 KB vs 64 KB), and the memory usage is independent of the > > window size. > > > > __DISABLE_EXPORTS is defined in misc.c instead of the Makefile because > > kaslr.c defines __DISABLE_EXPORTS, and defining it in the Makefile gives > > duplicate definition warnings. > > > > That was reported by Arvind - feel free to add a Reported-by: ... > > - Sedat - > It's not necessary to add Reported-by's for problems encountered while developing the series. Especially as it was my drive-by suggestion to use __DISABLE_EXPORTS that introduced the issue in the first place :) I'd have added it to the Makefile and just dropped the definition in kaslr.c -- should be no reason for anything in here to use EXPORT_SYMBOL. Thanks.