From: Gaurav Singh <gaurav1086@gmail.com>
To: gaurav1086@gmail.com,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Qiujun Huang <hqjagain@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Peter Rosin <peda@axentia.se>,
Nathan Chancellor <natechancellor@gmail.com>,
dri-devel@lists.freedesktop.org (open list:FRAMEBUFFER LAYER),
linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] [video/fbdev] fb_flashcursor: Remove redundant null check
Date: Sun, 26 Jul 2020 01:07:00 -0400 [thread overview]
Message-ID: <20200726050713.9461-1-gaurav1086@gmail.com> (raw)
ops cannot be NULL as its being accessed later without
checks. Remove the redundant NULL check.
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
---
drivers/video/fbdev/core/fbcon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index e2a490c5ae08..9551f40c6d14 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -401,7 +401,7 @@ static void fb_flashcursor(struct work_struct *work)
if (ret == 0)
return;
- if (ops && ops->currcon != -1)
+ if (ops->currcon != -1)
vc = vc_cons[ops->currcon].d;
if (!vc || !con_is_visible(vc) ||
--
2.17.1
next reply other threads:[~2020-07-26 5:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 5:07 Gaurav Singh [this message]
2020-07-26 8:58 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200726050713.9461-1-gaurav1086@gmail.com \
--to=gaurav1086@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=hqjagain@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=peda@axentia.se \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®