From: David Miller <davem@davemloft.net>
To: gaurav1086@gmail.com
Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [net/ipv6] ip6_output: Add ipv6_pinfo null check
Date: Mon, 27 Jul 2020 11:39:16 -0700 (PDT) [thread overview]
Message-ID: <20200727.113916.2247175777216104943.davem@davemloft.net> (raw)
In-Reply-To: <20200727033810.28883-1-gaurav1086@gmail.com>
From: Gaurav Singh <gaurav1086@gmail.com>
Date: Sun, 26 Jul 2020 23:38:10 -0400
> ipv6_pinfo is initlialized by inet6_sk() which returns NULL.
> Hence it can cause segmentation fault. Fix this by adding a
> NULL check.
Please take your time with such changes and actually look at the
compiler output, it will warn that you are adding a new problem.
Specifically, the function now fails to return a value at all.
But even more important, how is the situation you are fixing
possible? Do you have a sample crash? Can you please describe
the code paths and conditions that lead to the problem?
You must also provide a valid and properly formatted Fixes: tag
for bug fixes such as this.
Thank you.
next prev parent reply other threads:[~2020-07-27 18:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 3:38 Gaurav Singh
2020-07-27 5:18 ` kernel test robot
2020-07-27 10:34 ` kernel test robot
2020-07-27 18:39 ` David Miller [this message]
2020-07-27 19:50 ` Cong Wang
2020-07-28 2:13 ` Gaurav Singh
2020-07-28 3:12 ` Cong Wang
2020-07-28 14:41 ` Eric Dumazet
2020-08-08 17:06 ` Gaurav Singh
2020-08-08 17:37 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727.113916.2247175777216104943.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gaurav1086@gmail.com \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®