From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D46C6C433E3 for ; Mon, 27 Jul 2020 18:52:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6001207BB for ; Mon, 27 Jul 2020 18:52:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727905AbgG0SwU (ORCPT ); Mon, 27 Jul 2020 14:52:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbgG0SwU (ORCPT ); Mon, 27 Jul 2020 14:52:20 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 280AAC061794; Mon, 27 Jul 2020 11:52:20 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 38B46126BCA48; Mon, 27 Jul 2020 11:35:34 -0700 (PDT) Date: Mon, 27 Jul 2020 11:52:18 -0700 (PDT) Message-Id: <20200727.115218.1191292272155021831.davem@davemloft.net> To: matthieu.baerts@tessares.net Cc: netdev@vger.kernel.org, mathew.j.martineau@linux.intel.com, kuba@kernel.org, pabeni@redhat.com, mptcp@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] mptcp: fix joined subflows with unblocking sk From: David Miller In-Reply-To: <20200727102433.3422117-1-matthieu.baerts@tessares.net> References: <20200727102433.3422117-1-matthieu.baerts@tessares.net> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 27 Jul 2020 11:35:34 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matthieu Baerts Date: Mon, 27 Jul 2020 12:24:33 +0200 > Unblocking sockets used for outgoing connections were not containing > inet info about the initial connection due to a typo there: the value of > "err" variable is negative in the kernelspace. > > This fixes the creation of additional subflows where the remote port has > to be reused if the other host didn't announce another one. This also > fixes inet_diag showing blank info about MPTCP sockets from unblocking > sockets doing a connect(). > > Fixes: 41be81a8d3d0 ("mptcp: fix unblocking connect()") > Signed-off-by: Matthieu Baerts Applied, thanks!