From: David Miller <davem@davemloft.net>
To: wenhu.wang@vivo.com
Cc: elder@kernel.org, kuba@kernel.org, kvalo@codeaurora.org,
agross@kernel.org, bjorn.andersson@linaro.org, ohad@wizery.com,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, alsa-devel@alsa-project.org,
ath11k@lists.infradead.org, netdev@vger.kernel.org,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
srinivas.kandagatla@linaro.org, sibis@codeaurora.org
Subject: Re: [PATCH] soc: qmi: allow user to set handle wq to hiprio
Date: Mon, 27 Jul 2020 12:49:42 -0700 (PDT) [thread overview]
Message-ID: <20200727.124942.1829978531845134184.davem@davemloft.net> (raw)
In-Reply-To: <AMoAtwB9DXJsyd-1khUpzqq9.1.1595862196133.Hmail.wenhu.wang@vivo.com>
From: 王文虎 <wenhu.wang@vivo.com>
Date: Mon, 27 Jul 2020 23:03:16 +0800 (GMT+08:00)
> Currently the qmi_handle is initialized single threaded and strictly
> ordered with the active set to 1. This is pretty simple and safe but
> sometimes ineffency. So it is better to allow user to decide whether
> a high priority workqueue should be used.
>
> Signed-off-by: Wang Wenhu <wenhu.wang@vivo.com>
Every caller sets the new value to "0", so you should submit this when
you have a cast that actually sets it to "1".
Also, the new argument should be "bool" instead of "unsigned int" and
use "true" and "false" in the callers.
Thank you.
next prev parent reply other threads:[~2020-07-27 19:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 15:03 王文虎
2020-07-27 19:49 ` David Miller [this message]
2020-07-27 20:45 ` Bjorn Andersson
2020-08-02 13:14 ` 王文虎
2020-08-05 13:55 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727.124942.1829978531845134184.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=bjorn.andersson@linaro.org \
--cc=elder@kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=sibis@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=wenhu.wang@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®