From: Steffen Klassert <steffen.klassert@secunet.com>
To: B K Karthik <bkkarthik@pesu.pes.edu>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: xfrm: xfrm_policy.c: remove some unnecessary cases in decode_session6
Date: Mon, 27 Jul 2020 11:36:17 +0200 [thread overview]
Message-ID: <20200727093617.GZ20687@gauss3.secunet.de> (raw)
In-Reply-To: <20200725134949.z53thk4jubabiubd@pesu.pes.edu>
On Sat, Jul 25, 2020 at 07:19:49PM +0530, B K Karthik wrote:
> remove some unnecessary cases in decode_session6
>
> Signed-off-by: B K Karthik <bkkarthik@pesu.pes.edu>
> ---
> net/xfrm/xfrm_policy.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
> index 19c5e0fa3f44..e1c988a89382 100644
> --- a/net/xfrm/xfrm_policy.c
> +++ b/net/xfrm/xfrm_policy.c
> @@ -3449,10 +3449,6 @@ decode_session6(struct sk_buff *skb, struct flowi *fl, bool reverse)
> fl6->flowi6_proto = nexthdr;
> return;
> #endif
> - /* XXX Why are there these headers? */
> - case IPPROTO_AH:
> - case IPPROTO_ESP:
> - case IPPROTO_COMP:
> default:
> fl6->fl6_ipsec_spi = 0;
> fl6->flowi6_proto = nexthdr;
IPv4 implements spi parsing for these protocols, IPv6
does not do it. Before you just remove something, you
should think about which is the correct behaviour and
then do it for both, IPv4 and IPv6.
prev parent reply other threads:[~2020-07-27 9:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 13:49 B K Karthik
2020-07-27 9:36 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727093617.GZ20687@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=bkkarthik@pesu.pes.edu \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®