From: Steven Rostedt <rostedt@goodmis.org>
To: Tingwei Zhang <tingwei@codeaurora.org>
Cc: Ingo Molnar <mingo@redhat.com>,
tsoni@codeaurora.org,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Mao Jinlong <jinlmao@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/6] stm class: ftrace: use different channel accroding to CPU
Date: Mon, 27 Jul 2020 15:08:12 -0400 [thread overview]
Message-ID: <20200727150812.3051fa7d@oasis.local.home> (raw)
In-Reply-To: <20200726025931.30510-7-tingwei@codeaurora.org>
On Sun, 26 Jul 2020 10:59:31 +0800
Tingwei Zhang <tingwei@codeaurora.org> wrote:
> --- a/drivers/hwtracing/stm/ftrace.c
> +++ b/drivers/hwtracing/stm/ftrace.c
> @@ -37,8 +37,9 @@ static void notrace
> stm_ftrace_write(struct trace_export *export, const void *buf, unsigned int len)
> {
> struct stm_ftrace *stm = container_of(export, struct stm_ftrace, ftrace);
> + unsigned int cpu = smp_processor_id();
Probably should add a comment to the above stating that this is called
from the tracing system with preemption disabled.
Other than my two comments:
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
>
> - stm_source_write(&stm->data, STM_FTRACE_CHAN, buf, len);
> + stm_source_write(&stm->data, STM_FTRACE_CHAN + cpu, buf, len);
> }
>
> static int stm_ftrace_link(struct stm_source_data *data)
next prev parent reply other threads:[~2020-07-27 19:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 2:59 [PATCH v2 0/6] tracing: export event trace and trace_marker Tingwei Zhang
2020-07-26 2:59 ` [PATCH v2 1/6] stm class: ftrace: change dependency to TRACING Tingwei Zhang
2020-07-26 2:59 ` [PATCH v2 2/6] tracing: add flag to control different traces Tingwei Zhang
2020-07-27 18:45 ` Steven Rostedt
2020-07-28 0:29 ` Tingwei Zhang
2020-07-26 2:59 ` [PATCH v2 3/6] tracing: add trace_export support for event trace Tingwei Zhang
2020-07-26 2:59 ` [PATCH v2 4/6] tracing: add trace_export support for trace_marker Tingwei Zhang
2020-07-26 2:59 ` [PATCH v2 5/6] stm class: ftrace: enable supported trace export flag Tingwei Zhang
2020-07-26 2:59 ` [PATCH v2 6/6] stm class: ftrace: use different channel accroding to CPU Tingwei Zhang
2020-07-27 19:08 ` Steven Rostedt [this message]
2020-07-28 0:28 ` Tingwei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727150812.3051fa7d@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=jinlmao@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=tingwei@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome