From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44E28C433E1 for ; Tue, 28 Jul 2020 21:24:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 186FA2065C for ; Tue, 28 Jul 2020 21:24:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729442AbgG1VYV (ORCPT ); Tue, 28 Jul 2020 17:24:21 -0400 Received: from mga12.intel.com ([192.55.52.136]:29354 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729243AbgG1VYU (ORCPT ); Tue, 28 Jul 2020 17:24:20 -0400 IronPort-SDR: Q0w5bOyuvgW6TaCV7LcTDMGUGzps+asVBwCOhzZbdt3qIJAFxixlGxO4nK6QCml+ke6tcsoAaE J83kdkT4Orhg== X-IronPort-AV: E=McAfee;i="6000,8403,9696"; a="130877351" X-IronPort-AV: E=Sophos;i="5.75,407,1589266800"; d="scan'208";a="130877351" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2020 14:24:20 -0700 IronPort-SDR: 0wRBq9msnHmGxyTaWt+3wdxaRXlmo5roR3jTrRyBuokoK0IJAe4p9uNhxDVrvv1bF2VhwDgGA/ RbW3zZEH+CVg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,407,1589266800"; d="scan'208";a="490514452" Received: from otc-chromeosbuild-1.jf.intel.com ([10.54.30.83]) by fmsmga005.fm.intel.com with ESMTP; 28 Jul 2020 14:24:20 -0700 From: Azhar Shaikh To: bleung@chromium.org, enric.balletbo@collabora.com, groeck@chromium.org, pmalani@chromium.org, linux-kernel@vger.kernel.org Cc: heikki.krogerus@linux.intel.com, azhar.shaikh@intel.com, utkarsh.h.patel@intel.com, casey.g.bowman@intel.com, rajmohan.mani@intel.com Subject: [PATCH] platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role() Date: Tue, 28 Jul 2020 14:24:46 -0700 Message-Id: <20200728212446.2699-1-azhar.shaikh@intel.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org usb_role_switch_set_role() has the second argument as enum for usb_role. Currently depending upon the data role i.e. UFP(0) or DFP(1) is sent. This eventually translates to USB_ROLE_NONE in case of UFP and USB_ROLE_DEVICE in case of DFP. Correct this by sending correct enum values as USB_ROLE_DEVICE in case of UFP and USB_ROLE_HOST in case of UFP. Fixes: 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux control") Signed-off-by: Azhar Shaikh Cc: Prashant Malani --- drivers/platform/chrome/cros_ec_typec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index 3eae01f4c9f7..eb4713b7ae14 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -590,7 +590,8 @@ static int cros_typec_port_update(struct cros_typec_data *typec, int port_num) dev_warn(typec->dev, "Configure muxes failed, err = %d\n", ret); return usb_role_switch_set_role(typec->ports[port_num]->role_sw, - !!(resp.role & PD_CTRL_RESP_ROLE_DATA)); + resp.role & PD_CTRL_RESP_ROLE_DATA + ? USB_ROLE_HOST : USB_ROLE_DEVICE); } static int cros_typec_get_cmd_version(struct cros_typec_data *typec) -- 2.17.1