From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2353BC433E0 for ; Wed, 29 Jul 2020 11:21:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09AE4207FC for ; Wed, 29 Jul 2020 11:21:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726711AbgG2LVF (ORCPT ); Wed, 29 Jul 2020 07:21:05 -0400 Received: from mga18.intel.com ([134.134.136.126]:55036 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726496AbgG2LVF (ORCPT ); Wed, 29 Jul 2020 07:21:05 -0400 IronPort-SDR: 18iHv6XdLqFXD35fSjkb7J4wShsS9ScKZH8jDb82a01za2ChQBUshzX1sEutqD1v3Y23HeEzFo 6jcRR70ZrONQ== X-IronPort-AV: E=McAfee;i="6000,8403,9696"; a="138926296" X-IronPort-AV: E=Sophos;i="5.75,410,1589266800"; d="scan'208";a="138926296" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2020 04:21:01 -0700 IronPort-SDR: uqPcMaoUSfpo404KJkP5rqAgdej4Bq4CoZPFgIA0ojK34SC5ckBeziVeNCr3s0uvbDpJskNQdK aZiFwh7DhfeQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,410,1589266800"; d="scan'208";a="364818643" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001.jf.intel.com with ESMTP; 29 Jul 2020 04:20:57 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1k0k8f-004gBc-KZ; Wed, 29 Jul 2020 14:20:49 +0300 Date: Wed, 29 Jul 2020 14:20:49 +0300 From: Andy Shevchenko To: Brent Lu Cc: alsa-devel@alsa-project.org, Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , Mark Brown , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , Ranjani Sridharan , linux-kernel@vger.kernel.org, Daniel Stuart , Yu-Hsuan Hsu , Guennadi Liakhovetski , Kai Vehmanen , Sam McNally , Damian van Soelen Subject: Re: [PATCH 0/2] Add period size constraint for Atom Chromebook Message-ID: <20200729112049.GW3703480@smile.fi.intel.com> References: <1596020585-11517-1-git-send-email-brent.lu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1596020585-11517-1-git-send-email-brent.lu@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 29, 2020 at 07:03:03PM +0800, Brent Lu wrote: > Two different constraints are implemented: one is in platform's CPU > DAI to enforce period sizes which are already used in Android BSP. The > other is in Atom Chromebook's machine driver to use 240 as period size. One nit to one patch. Overall, LGTM and thus FWIW, Reviewed-by: Andy Shevchenko > Brent Lu (1): > ASoC: intel: atom: Add period size constraint > > Yu-Hsuan Hsu (1): > ASoC: Intel: Add period size constraint on strago board > > sound/soc/intel/atom/sst-mfld-platform-pcm.c | 15 +++++++++++++++ > sound/soc/intel/boards/cht_bsw_max98090_ti.c | 14 +++++++++++++- > sound/soc/intel/boards/cht_bsw_rt5645.c | 14 +++++++++++++- > 3 files changed, 41 insertions(+), 2 deletions(-) > > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko