mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rodrigo Madera <rodrigo.madera@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: christian.brauner@ubuntu.com, linux-kernel@vger.kernel.org
Subject: Re: bpfilter logging write errors in dmesg
Date: Thu, 30 Jul 2020 12:55:27 -0300	[thread overview]
Message-ID: <20200730155527.GB1829@supreme> (raw)
In-Reply-To: <20200730060654.GA17803@lst.de>

On Thu, Jul 30, 2020 at 08:06:54AM +0200, Christoph Hellwig wrote:
> Ho Rodrigo,
> 
> please try this patch:
> 
> diff --git a/net/bpfilter/bpfilter_kern.c b/net/bpfilter/bpfilter_kern.c
> index 1905e01c3aa9a7..4494ea6056cdb8 100644
> --- a/net/bpfilter/bpfilter_kern.c
> +++ b/net/bpfilter/bpfilter_kern.c
> @@ -39,7 +39,7 @@ static int __bpfilter_process_sockopt(struct sock *sk, int optname,
>  {
>  	struct mbox_request req;
>  	struct mbox_reply reply;
> -	loff_t pos;
> +	loff_t pos = 0;
>  	ssize_t n;
>  	int ret = -EFAULT;
>  

Christoph,

This killed the issue!

Can't believe I missed it... The pos numbers were a dead giveaway!

Let me know if you wish to do any other tests on my end.

Best regards,
Madera


  reply	other threads:[~2020-07-30 15:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27 10:46 Christian Brauner
2020-07-27 13:28 ` Christoph Hellwig
2020-07-27 14:13   ` Christian Brauner
2020-07-27 14:21     ` Christian Brauner
2020-07-27 14:50     ` Christoph Hellwig
2020-07-30  0:59       ` Rodrigo Madera
2020-07-30  6:06         ` Christoph Hellwig
2020-07-30 15:55           ` Rodrigo Madera [this message]
2020-07-30  7:09       ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200730155527.GB1829@supreme \
    --to=rodrigo.madera@gmail.com \
    --cc=christian.brauner@ubuntu.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome