From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BC52C433E0 for ; Thu, 30 Jul 2020 18:17:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0ABD12083E for ; Thu, 30 Jul 2020 18:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596133022; bh=LBCwuVVf2MFMPMEHXM5IvbF8TsLWJpQcKK8QGu1gYp8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=toNGvICzLmehbSkigNQY1FFEjeVET8es2dYLCEALWoQJC4mKu2lbeWjXnzIzZKg87 MX55ktRHE/AdSlnHPR3EI4q3HBW+v7fMS/iluWqjAJ2nWMo5YxPaMYr62o68Ti+Du7 j+G/iAyQV+xoDQL0JErL1mQrTIb3UZMXKmc5B3mQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728489AbgG3SRA (ORCPT ); Thu, 30 Jul 2020 14:17:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:51644 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726581AbgG3SRA (ORCPT ); Thu, 30 Jul 2020 14:17:00 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D6AA20829; Thu, 30 Jul 2020 18:16:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596133019; bh=LBCwuVVf2MFMPMEHXM5IvbF8TsLWJpQcKK8QGu1gYp8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rwq0nnZj/hIgvH8uNBimB+cd8SjqqJMtQnnMlxXej5RIfBUckzOQvJdYznOX/gFC1 /5l+CPMhHKGIFDjovC6MrhJmRay6Pv6Fypo4qqiobgGCp5VAEA7JO2N0ZTQ9PGX//b bgvfhRAYufUeGmxt/W+oMOlIjxVsCCEDMZeuQgw0= Date: Thu, 30 Jul 2020 19:16:39 +0100 From: Mark Brown To: Dmitry Torokhov Cc: Greg Kroah-Hartman , Andrzej Hajda , Jernej Skrabec , Bartlomiej Zolnierkiewicz , Jonas Karlman , lkml , "open list:DRM DRIVERS" , Russell King - ARM Linux , Neil Armstrong , Andy Shevchenko , Laurent Pinchart , "Rafael J. Wysocki" , linux-arm-kernel , Marek Szyprowski Subject: Re: [PATCH v9 0/4] driver core: add probe error check helper Message-ID: <20200730181639.GG5055@sirena.org.uk> References: <20200713144324.23654-1-a.hajda@samsung.com> <20200730070832.GA4045592@kroah.com> <20200730164845.GE5055@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OFj+1YLvsEfSXdCH" Content-Disposition: inline In-Reply-To: X-Cookie: Alex Haley was adopted! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --OFj+1YLvsEfSXdCH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 30, 2020 at 10:46:31AM -0700, Dmitry Torokhov wrote: > On Thu, Jul 30, 2020 at 9:49 AM Mark Brown wrote: > > The error messages are frequently in the caller rather than the > > frameworks, it's often helpful for the comprehensibility of the error > > messages especially in cases where things may be legitimately absent. > Not for deferral. All you need to know in this case is: > "device A is attempting to request resource B which is not ready yet" > There is nothing to handle on the caller part except to float the error up. You can sometimes do a better job of explaining what the resource you were looking for was, and of course you still need diagnostics in the non-deferral case. Whatever happens we'll need a lot of per-driver churn, either removing existing diagnostics that get factored into cores or updating to use this new API. --OFj+1YLvsEfSXdCH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8jDoYACgkQJNaLcl1U h9A2DQf5AbA6hQnpkocd7NNW+Fw34/watcpGeOf4wGfEJJJ4gI4gUx6kg6uRWIA3 UgGG/DpJJATR3MPX7tldkjFb65ha6uxYu7Vv2/hHbGYepe+0ta2ne1R/DMePZC6x RTi7Fp5kuRndOAYjdJYTKWHDPh/Wq1eqaZ7qQVmon4pTuj/MxQwGARkI9eaw2/B0 PxQCmeNPpAadkihizL2VQQdf/L8kL0OsGieJq/SF2Dcv7gp6XWcddLBzTX2hhWhd 2ZODZdYj0aaQwirjVx2ckwl6Ijioaod+RslHEYfoLWjIHRV0326rQjKMqhHjhaQ8 P6vn0hVhQYM8huV6o6MxPRLHutQ4fw== =OEO+ -----END PGP SIGNATURE----- --OFj+1YLvsEfSXdCH--