From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFA2DC433E1 for ; Thu, 30 Jul 2020 19:06:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0B9D20829 for ; Thu, 30 Jul 2020 19:06:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596136017; bh=1I8fO+aOE4GM8YnM8qo4Nuupe+/TzUrSp9geRjuPg7k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mpLlzEE1ngSms920rbABH7WHw0+uoE7qY94wmQj1a1UQmNCqJkOp/YJwBqE0wUTdg 4kGUL7OmQHJi/0SKd494+zpy9Fju4pFG4to80Sg3sbYzLLTVzcaEb9hg2d24ZikcVu CWG2Ksvr4CoeAODHvoifLlElaL/h2JoTyqDTKbuE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730423AbgG3TG4 (ORCPT ); Thu, 30 Jul 2020 15:06:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:35978 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728644AbgG3TG4 (ORCPT ); Thu, 30 Jul 2020 15:06:56 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1D97206F5; Thu, 30 Jul 2020 19:06:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596136015; bh=1I8fO+aOE4GM8YnM8qo4Nuupe+/TzUrSp9geRjuPg7k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zTI8TKPGCH5TvgmEZYVPZIu/SeTLs5dEOoKzcI8T5sGbuA4syJ7F4F59AJtqNkfTN IdQBuDXBoqIsIUodnJf8xzVyLbeV+gpv0gLLzRbfnncnFt67La4zr2MkMNS9EdF5DZ r05Orm18MH5SwELFo/25PICbJjNRLvMxxJLSm7y8= Date: Thu, 30 Jul 2020 20:06:35 +0100 From: Mark Brown To: Dmitry Torokhov Cc: Greg Kroah-Hartman , Andrzej Hajda , Jernej Skrabec , Bartlomiej Zolnierkiewicz , Jonas Karlman , lkml , "open list:DRM DRIVERS" , Russell King - ARM Linux , Neil Armstrong , Andy Shevchenko , Laurent Pinchart , "Rafael J. Wysocki" , linux-arm-kernel , Marek Szyprowski Subject: Re: [PATCH v9 0/4] driver core: add probe error check helper Message-ID: <20200730190634.GI5055@sirena.org.uk> References: <20200713144324.23654-1-a.hajda@samsung.com> <20200730070832.GA4045592@kroah.com> <20200730164845.GE5055@sirena.org.uk> <20200730181639.GG5055@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6b3yLyRKT1M6kiA0" Content-Disposition: inline In-Reply-To: X-Cookie: Alex Haley was adopted! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6b3yLyRKT1M6kiA0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 30, 2020 at 11:45:25AM -0700, Dmitry Torokhov wrote: > On Thu, Jul 30, 2020 at 11:16 AM Mark Brown wrote: > > You can sometimes do a better job of explaining what the resource you > > were looking for was, > I think it is true for very esoteric cases. I.e. your driver uses 2 > interrupt lines, or something like that. For GPIO, regulators, and > clocks we normally have a name/connection ID that provides enough of *Normally* but not always - some of the older bindings do love their arrays of phandles (or mixes of numbers and phandles!) unfortunately. > context. We need to remember, the error messages really only make > total sense to a person familiar with the driver to begin with, not > for a random person looking at the log. Not really, one of the big targets is people doing system integration who are writing a DT or possibly producing a highly tuned kernel config. They needn't have a strong familiarity with the driver, they're often just picking it up off the shelf. > > and of course you still need diagnostics in the > > non-deferral case. Whatever happens we'll need a lot of per-driver > > churn, either removing existing diagnostics that get factored into cores > > or updating to use this new API. > The point is if you push it into core you'll get the benefit of > notifying about the deferral (and can "attach" deferral reason to a > device) without changing drivers at all. You can clean them up later > if you want, or decide that additional logging in error paths does not > hurt. This new API does not do you any good unless you convert > drivers, and you need to convert the majority of them to be able to > rely on the deferral diagnostic that is being added. The push for this is that there's already people going around modifying drivers whatever happens but at present they're mainly trying to delete diagnostics which isn't wonderful. Besides, even if we push things into the subsystems they'd want to use this interface or something quite like it anyway - it's more a question of if we go quickly add some users to subsystems isn't it? I'm not against that. --6b3yLyRKT1M6kiA0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8jGjoACgkQJNaLcl1U h9BywAf8C7mJ7xiPFi7qLH/+T9F0CBF3SL6/ubMOaNhmgrWz+rz2qb5TTQ1adyjl GiUu7DQbZhoWvWxb/8fqdy4BufqP58KbV53l0Oy6loVslM914RzzWcHv2hRT16wn nMTVtBOfXjxT6Dv6UYNQs7a3XxaOLFx6SNDydn5bAoQNxz2r6+lPCIlevPOIVwyV W41iFyk6AeACKSDbKSi7R/eP8apDELZTV1JQMv9kFQjPi0Qn+g/BvH6AjtJWlBke CssSrTU7H/Ifu0yJqGaCyYWHgb8A7C8A4NOYpHwbkwhJ0q8bT3BbMlc7785n8C08 MT1LDTbH/SJqhnox2e+FWjcDkEyAJA== =Dnzb -----END PGP SIGNATURE----- --6b3yLyRKT1M6kiA0--