From: David Miller <davem@davemloft.net>
To: jasowang@redhat.com
Cc: kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, mst@redhat.com
Subject: Re: [PATCH net-next] tun: add missing rcu annotation in tun_set_ebpf()
Date: Fri, 31 Jul 2020 17:18:17 -0700 (PDT) [thread overview]
Message-ID: <20200731.171817.1478408613409998661.davem@davemloft.net> (raw)
In-Reply-To: <20200731041720.61187-1-jasowang@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Date: Fri, 31 Jul 2020 00:17:20 -0400
> We expecte prog_p to be protected by rcu, so adding the rcu annotation
> to fix the following sparse warning:
>
> drivers/net/tun.c:3003:36: warning: incorrect type in argument 2 (different address spaces)
> drivers/net/tun.c:3003:36: expected struct tun_prog [noderef] __rcu **prog_p
> drivers/net/tun.c:3003:36: got struct tun_prog **prog_p
> drivers/net/tun.c:3292:42: warning: incorrect type in argument 2 (different address spaces)
> drivers/net/tun.c:3292:42: expected struct tun_prog **prog_p
> drivers/net/tun.c:3292:42: got struct tun_prog [noderef] __rcu **
> drivers/net/tun.c:3296:42: warning: incorrect type in argument 2 (different address spaces)
> drivers/net/tun.c:3296:42: expected struct tun_prog **prog_p
> drivers/net/tun.c:3296:42: got struct tun_prog [noderef] __rcu **
>
> Reported-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2020-08-01 0:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 4:17 Jason Wang
2020-08-01 0:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731.171817.1478408613409998661.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®