From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28926C433DF for ; Sun, 2 Aug 2020 14:23:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFEC120759 for ; Sun, 2 Aug 2020 14:23:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Erj3Mq7s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726282AbgHBOXu (ORCPT ); Sun, 2 Aug 2020 10:23:50 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:26934 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725780AbgHBOXt (ORCPT ); Sun, 2 Aug 2020 10:23:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596378228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=2/kHNXwW/Okw1oeFagoA94XTuvPYMO2ieikygdNu33E=; b=Erj3Mq7sCoAsePSyM9uTtcVGmZNB5aknHoaeFRYUiebTKHGbxts3am1Ntp8osMpsmQ+BAV eYbAqbXculULk14YwXtmT/BErUb2rWz9pQp16OaXUnlWxHM0QtCIzUV0l0UOd1+egC0Lwg Hc9R6W3oFNb4b2HaP+4AgvLqli3gOmo= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-257-96u3dJ5bPJGxpffmzPcAag-1; Sun, 02 Aug 2020 10:23:46 -0400 X-MC-Unique: 96u3dJ5bPJGxpffmzPcAag-1 Received: by mail-qv1-f72.google.com with SMTP id l18so5879778qvq.16 for ; Sun, 02 Aug 2020 07:23:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2/kHNXwW/Okw1oeFagoA94XTuvPYMO2ieikygdNu33E=; b=ufzSnXN3+46Ij3TZApm/4yV4lYKrrPiPV18Dw0sjW+lxBDzpAURjM9FM9LnIjyR0KR 4cT13uz9G+n9gq1T5yUz8FcFwO142oyaXznp3PsEVd62l4u0M0UGZT42667MHzHBDm8D ReFT+mP1oFIsHIkGzewIRg7XGtBcCAqmzLfiEfuzEb5PsTwzOoXAsNWZyojppMt7c40i 38N+c8kc0gEVzYiIoRZUjtzfVtaMU8NltPumNlWpuajgHMBiiW0HBMi7JjSQ9ys0JHwA 1jh/7k4pP5P+uzGYsgdH+xHoNWehGWUarz2OSkL6Hb54QCpoqqmGPsbZGU478AmJG1BQ GFsw== X-Gm-Message-State: AOAM530t5B7H3k/aCQzqgngybAhHHOokutHKv3hPyQjvX4kuXwD/J0q1 iURuziWPxWMl3dDf0+zdZpJzU5nsQl69KWlav/BvcR71Hv51RmIt6dXiFArlHC93xWt+mW8t8br 3759UIpk1UXIkNyoGVzPguTW3 X-Received: by 2002:a37:62cc:: with SMTP id w195mr12855863qkb.33.1596378226336; Sun, 02 Aug 2020 07:23:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgE09Sl0MfhLOKvnnEluSkBTqBNuCaM3HjAVewFzyYuhdgdEgcM4E45wQlwXc1nshAvd3KIA== X-Received: by 2002:a37:62cc:: with SMTP id w195mr12855832qkb.33.1596378226027; Sun, 02 Aug 2020 07:23:46 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id g61sm18050245qtd.65.2020.08.02.07.23.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2020 07:23:45 -0700 (PDT) From: trix@redhat.com To: michael.hennerich@analog.com, alex.aring@gmail.com, stefan@datenfreihafen.org, davem@davemloft.net, kuba@kernel.org, marcel@holtmann.org Cc: linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] ieee802154/adf7242: check status of adf7242_read_reg Date: Sun, 2 Aug 2020 07:23:39 -0700 Message-Id: <20200802142339.21091-1-trix@redhat.com> X-Mailer: git-send-email 2.18.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Rix Clang static analysis reports this error adf7242.c:887:6: warning: Assigned value is garbage or undefined len = len_u8; ^ ~~~~~~ len_u8 is set in adf7242_read_reg(lp, 0, &len_u8); When this call fails, len_u8 is not set. So check the return code. Fixes: 7302b9d90117 ("ieee802154/adf7242: Driver for ADF7242 MAC IEEE802154") Signed-off-by: Tom Rix --- drivers/net/ieee802154/adf7242.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c index c11f32f644db..7db9cbd0f5de 100644 --- a/drivers/net/ieee802154/adf7242.c +++ b/drivers/net/ieee802154/adf7242.c @@ -882,7 +882,9 @@ static int adf7242_rx(struct adf7242_local *lp) int ret; u8 lqi, len_u8, *data; - adf7242_read_reg(lp, 0, &len_u8); + ret = adf7242_read_reg(lp, 0, &len_u8); + if (ret) + return ret; len = len_u8; -- 2.18.1