mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Jacopo Mondi <jacopo@jmondi.org>,
	Steve Longerbeam <slongerbeam@gmail.com>,
	Hugues Fruchet <hugues.fruchet@st.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Biju Das <biju.das.jz@bp.renesas.com>,
	Prabhakar <prabhakar.csengg@gmail.com>,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: media: i2c: ov5640: Document bus-type property
Date: Tue, 4 Aug 2020 11:14:59 +0300	[thread overview]
Message-ID: <20200804081458.GC13316@paasikivi.fi.intel.com> (raw)
In-Reply-To: <1596465107-14251-2-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com>

Hi Prabhakar,

Thanks for the update.

On Mon, Aug 03, 2020 at 03:31:44PM +0100, Lad Prabhakar wrote:
> Document the possible bus-type's supported by the OV5640 sensor driver.
> 
> Also add the bus-type in example node.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/media/i2c/ov5640.txt | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5640.txt b/Documentation/devicetree/bindings/media/i2c/ov5640.txt
> index c97c2f2da12d..00131dbb147e 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ov5640.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/ov5640.txt
> @@ -36,9 +36,15 @@ Endpoint node required properties for parallel connection are:
>  - data-shift: shall be set to <2> for 8 bits parallel bus
>  	      (lines 9:2 are used) or <0> for 10 bits parallel bus
>  - hsync-active: active state of the HSYNC signal, 0/1 for LOW/HIGH respectively.
> +		(Required for bus-type 5)
>  - vsync-active: active state of the VSYNC signal, 0/1 for LOW/HIGH respectively.
> +		(Required for bus-type 5)
>  - pclk-sample: sample data on rising (1) or falling (0) edge of the pixel clock
> -	       signal.
> +	       signal. (Required for bus-type 5)
> +- bus-type: data bus type. Possible values are:
> +	    4 - MIPI CSI-2 D-PHY
> +	    5 - Parallel
> +	    6 - Bt.656

This is under required parallel properties. You could document value 4
under CSI-2 related properties.

>  
>  Examples:
>  
> @@ -86,6 +92,7 @@ Examples:
>  				hsync-active = <0>;
>  				vsync-active = <0>;
>  				pclk-sample = <1>;
> +				bus-type = <5>;
>  			};
>  		};
>  	};

-- 
Regards,

Sakari Ailus

  reply	other threads:[~2020-08-04  8:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 14:31 [PATCH v2 0/4] media: i2c: ov5640 feature enhancement and fixes Lad Prabhakar
2020-08-03 14:31 ` [PATCH v2 1/4] dt-bindings: media: i2c: ov5640: Document bus-type property Lad Prabhakar
2020-08-04  8:14   ` Sakari Ailus [this message]
2020-08-05  8:05     ` Lad, Prabhakar
2020-08-03 14:31 ` [PATCH v2 2/4] media: i2c: ov5640: Enable data pins on poweron for DVP mode Lad Prabhakar
2020-08-06 16:30   ` Jacopo Mondi
2020-08-06 16:38     ` Lad, Prabhakar
2020-08-07  8:46       ` Jacopo Mondi
2020-08-10  7:40         ` Lad, Prabhakar
2020-08-10  8:42           ` Jacopo Mondi
2020-08-10  8:50             ` Lad, Prabhakar
2020-08-03 14:31 ` [PATCH v2 3/4] media: i2c: ov5640: Add support for BT656 mode Lad Prabhakar
2020-09-10 10:09   ` Hugues FRUCHET
2020-08-03 14:31 ` [PATCH v2 4/4] media: i2c: ov5640: Fallback to parallel mode Lad Prabhakar
2020-08-04  8:18   ` Sakari Ailus
2020-08-05  8:32     ` Lad, Prabhakar
2020-08-06 14:48 ` [PATCH v2 0/4] media: i2c: ov5640 feature enhancement and fixes Jacopo Mondi
2020-08-10  7:25   ` Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200804081458.GC13316@paasikivi.fi.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hugues.fruchet@st.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=jacopo@jmondi.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    --cc=slongerbeam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®