From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=pusq=BO=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 78A42C433E0
	for <linux-kernel@archiver.kernel.org>; Tue,  4 Aug 2020 12:10:58 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 5747C22B42
	for <linux-kernel@archiver.kernel.org>; Tue,  4 Aug 2020 12:10:58 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1596543058;
	bh=R+Foz/8zo9+GgInhMqlvYCUr1NnxOx7pfypaHXJtLWU=;
	h=Date:From:To:Subject:References:In-Reply-To:List-ID:From;
	b=TA52P2A9r+gLQDdIv3F5G3Sn7esjgBcntc24s7UISOvJs4xq9Qi2K6ijMYQrBFLI6
	 B5fW0iKJ/7ufmtGQvkYVfPT0ekPVpsYqev0YVejhjsTsML9ydErQp5USSZt+8Ky9N6
	 rBpqj4tr6cG/311N2SoHLBJdxujncefxxVRCDHUs=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726399AbgHDMGm (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 4 Aug 2020 08:06:42 -0400
Received: from mail.kernel.org ([198.145.29.99]:39428 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1730392AbgHDL5x (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 4 Aug 2020 07:57:53 -0400
Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 53641208A9;
        Tue,  4 Aug 2020 11:57:10 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1596542230;
        bh=R+Foz/8zo9+GgInhMqlvYCUr1NnxOx7pfypaHXJtLWU=;
        h=Date:From:To:Subject:References:In-Reply-To:From;
        b=ET8j1kSfWY6jHru5raK6NT3mqrxz3v7kY1krCYzhz+E6sE0bOwwGXa5kR6WG5l+F4
         t5GzhPIgTX9huR5qmEhYxFVcmtVpUJznvNbYuAc9EwVNCNXpwK/1IjAtJGcubWZfLp
         3xJ+2DVeN6f4YMugSyc7NFCN6J/8WyQFjBqvEASM=
Date:   Tue, 4 Aug 2020 13:56:50 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Samuel Thibault <samuel.thibault@ens-lyon.org>,
        linux-kernel@vger.kernel.org, speakup@linux-speakup.org
Subject: Re: [PATCH 2/2] speakup: only build serialio when ISA is enabled
Message-ID: <20200804115650.GB203147@kroah.com>
References: <20200804111332.dex7jobmabifdzw5@function>
 <20200804113413.GA181242@kroah.com>
 <20200804114951.ijs3hnezi4f64nll@function>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200804114951.ijs3hnezi4f64nll@function>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 04, 2020 at 01:49:51PM +0200, Samuel Thibault wrote:
> Greg KH, le mar. 04 août 2020 13:34:13 +0200, a ecrit:
> > On Tue, Aug 04, 2020 at 01:13:32PM +0200, Samuel Thibault wrote:
> > > Drivers using serialio are already made available in Kconfig only under
> > > the ISA condition.
> > > 
> > > This solves warnings in inb/outb macros on platform that do not have 
> > > support for ISA.
> > > 
> > > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> > > 
> > > Index: linux-2.6/drivers/accessibility/speakup/Makefile
> > > ===================================================================
> > > --- linux-2.6.orig/drivers/accessibility/speakup/Makefile
> > > +++ linux-2.6/drivers/accessibility/speakup/Makefile
> > > @@ -16,6 +16,7 @@ obj-$(CONFIG_SPEAKUP_SYNTH_TXPRT) += spe
> > >  obj-$(CONFIG_SPEAKUP_SYNTH_DUMMY) += speakup_dummy.o
> > >  
> > >  obj-$(CONFIG_SPEAKUP) += speakup.o
> > > +obj-$(CONFIG_ISA) += serialio.o
> > >  speakup-y := \
> > >  	buffers.o \
> > >  	devsynth.o \
> > > @@ -25,7 +26,6 @@ speakup-y := \
> > >  	keyhelp.o \
> > >  	kobjects.o \
> > >  	selection.o \
> > > -	serialio.o \
> > >  	spk_ttyio.o \
> > >  	synth.o \
> > >  	thread.o \
> > 
> > Oops, no, I get the following build errors with this patch:
> > 
> > ERROR: modpost: "spk_wait_for_xmitr" [drivers/accessibility/speakup/speakup.ko] undefined!
> 
> Yes, it depends on the first of the queue.

Ah, missed that, ok, let me try this again...