From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30507C433DF for ; Tue, 4 Aug 2020 14:24:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FF7E22D03 for ; Tue, 4 Aug 2020 14:24:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="YaID0GqX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728990AbgHDOYY (ORCPT ); Tue, 4 Aug 2020 10:24:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728903AbgHDOX6 (ORCPT ); Tue, 4 Aug 2020 10:23:58 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80364C06174A; Tue, 4 Aug 2020 07:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=k3hHT8hBP3vIg+5n2HC1ywURgKIRKUgYzqnMS2vhhdM=; b=YaID0GqXpy1LpLRHHrlA5ZgUdz YRGNR6WocYcAEBMUYF6t2biBQQZsEFcHxoQjE9fZYjLOXGJvpnh17wTBwaWVviPibgVhjtzD1VpNl CXYJfWd6M0ExGPid892N2ilOazv9V15LYR0KDCJcB58l52fAtPISo6oZohbygZn1JD6R8o3EvvKJ0 Mht2Ln7RQbdCwW6RIIT8QRChYwE6jcSTh01gvuhnDUVvaKgrbVrfETGDK9EsEGiZovSfSYX3GVzmO shjByq9fco8EqvTIr1/L1omF4lOkIZVQX82BF7paNS2+MsJFJuBPh/3IvmeI8gWNmTqqKPz4bK0qP LEmOq8jQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2xr0-0004yR-9p; Tue, 04 Aug 2020 14:23:46 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 3F2F730477A; Tue, 4 Aug 2020 16:23:44 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 281592B7C12A3; Tue, 4 Aug 2020 16:23:44 +0200 (CEST) Date: Tue, 4 Aug 2020 16:23:44 +0200 From: peterz@infradead.org To: Vitor Massaru Iha Cc: KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , Brendan Higgins , Shuah Khan , linux-kernel-mentees@lists.linuxfoundation.org, Ian Rogers , mingo@kernel.org Subject: Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit Message-ID: <20200804142344.GM2674@hirez.programming.kicks-ass.net> References: <20200729201146.537433-1-vitor@massaru.org> <20200729203908.GD2655@hirez.programming.kicks-ass.net> <20200804132517.GK2657@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 04, 2020 at 10:46:21AM -0300, Vitor Massaru Iha wrote: > On Tue, Aug 4, 2020 at 10:25 AM wrote: > > On Wed, Jul 29, 2020 at 06:57:17PM -0300, Vitor Massaru Iha wrote: > > > > > The results can be seen this way: > > > > > > This is an excerpt from the test.log with the result in TAP format: > > > [snip] > > > ok 5 - example > > > # Subtest: min-heap > > > 1..6 > > > ok 1 - test_heapify_all_true > > > ok 2 - test_heapify_all_false > > > ok 3 - test_heap_push_true > > > ok 4 - test_heap_push_false > > > ok 5 - test_heap_pop_push_true > > > ok 6 - test_heap_pop_push_false > > > [snip] So ^ is TAP format? > > I don't care or care to use either; what does dmesg do? It used to be > > that just building the self-tests was sufficient and any error would > > show in dmesg when you boot the machine. > > > > But if I now have to use some damn tool, this is a regression. > > If you don't want to, you don't need to use the kunit-tool. If you > compile the tests as builtin and run the Kernel on your machine > the test result will be shown in dmesg in TAP format. That's seems a lot more verbose than it is now. I've recently even done a bunch of tests that don't print anything on success, dmesg is clutter enough already.