mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Rob Herring <robh@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: rcar-gen2: Fix crash in resource_list_first_type()
Date: Tue, 4 Aug 2020 11:22:23 -0500	[thread overview]
Message-ID: <20200804162223.GA420993@bjorn-Precision-5520> (raw)
In-Reply-To: <20200804161325.GA11104@e121166-lin.cambridge.arm.com>

On Tue, Aug 04, 2020 at 05:13:25PM +0100, Lorenzo Pieralisi wrote:
> On Tue, Aug 04, 2020 at 02:04:30PM +0200, Geert Uytterhoeven wrote:
> > The conversion to modern host bridge probing made the driver allocate
> > its private data using devm_pci_alloc_host_bridge(), but forgot to
> > remove the old allocation.  Hence part of the driver initialization is
> > done using the new instance, while another part is done using the old
> > instance, leading to a crash due to uninitialized bridge DMA ranges:
> > 
> >     Unable to handle kernel NULL pointer dereference at virtual address 00000008
> >     pgd = (ptrval)
> >     [00000008] *pgd=00000000
> >     Internal error: Oops: 5 [#1] SMP ARM
> >     CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.8.0-rc1-shmobile-00035-g92d69cc6275845a7 #645
> >     Hardware name: Generic R-Car Gen2 (Flattened Device Tree)
> >     PC is at rcar_pci_probe+0x154/0x340
> >     LR is at _raw_spin_unlock_irqrestore+0x18/0x20
> > 
> > Fix this by dropping the old allocation.
> > 
> > Fixes: 92d69cc6275845a7 ("PCI: rcar-gen2: Convert to use modern host bridge probe functions")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  drivers/pci/controller/pci-rcar-gen2.c | 4 ----
> >  1 file changed, 4 deletions(-)
> 
> Squashed in the initial commit, pushed out on pci/misc.

I updated my 'next' branch with this.

Rob, are there any similar issues in other drivers that we should fix
before asking Linus to pull this?

> > diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c
> > index 046965d284a6d54e..c9530038ca9a53fc 100644
> > --- a/drivers/pci/controller/pci-rcar-gen2.c
> > +++ b/drivers/pci/controller/pci-rcar-gen2.c
> > @@ -302,10 +302,6 @@ static int rcar_pci_probe(struct platform_device *pdev)
> >  	if (mem_res->start & 0xFFFF)
> >  		return -EINVAL;
> >  
> > -	priv = devm_kzalloc(dev, sizeof(struct rcar_pci_priv), GFP_KERNEL);
> > -	if (!priv)
> > -		return -ENOMEM;
> > -
> >  	priv->mem_res = *mem_res;
> >  	priv->cfg_res = cfg_res;
> >  
> > -- 
> > 2.17.1
> > 

  reply	other threads:[~2020-08-04 16:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04 12:04 Geert Uytterhoeven
2020-08-04 15:13 ` Rob Herring
2020-08-04 16:13 ` Lorenzo Pieralisi
2020-08-04 16:22   ` Bjorn Helgaas [this message]
2020-08-04 16:48     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200804162223.GA420993@bjorn-Precision-5520 \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=robh@kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®