From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6C88C433DF for ; Wed, 5 Aug 2020 17:52:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BF0C2073E for ; Wed, 5 Aug 2020 17:52:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596649932; bh=RiwzAtjuf8ObXHWny2WLgMqRBru3zrdleC7LsT+rj2k=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=h3aNCMsbaJpWFvOqXCTQGbCJZ/x5UYeTNcaFjO+Oruw4Krc3xKCmzk5CB6FXmrlCA ZXd2idB4P6YKNTYMVCNHtUmRreutqj6Bwh2LDK0ZclN0I8C6FlnOSkicsJgYt3LHQX 8iqIIfLBINp47nZ7dEwmDRziI3b+oEmTI5aTQnD4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729043AbgHERwL (ORCPT ); Wed, 5 Aug 2020 13:52:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:43118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728859AbgHERoA (ORCPT ); Wed, 5 Aug 2020 13:44:00 -0400 Received: from localhost (mobile-166-175-186-42.mycingular.net [166.175.186.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 674EB2073E; Wed, 5 Aug 2020 17:43:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596649411; bh=RiwzAtjuf8ObXHWny2WLgMqRBru3zrdleC7LsT+rj2k=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=F69wTfs8HLNpiiVRM2qh0nFb0ahhJsGPtuiG9HBGkxULkBpth/rtoOZNTjoemwM7g MviExTIi2gCogQEmcNwll+2dvxpsmQGGnKdC/nq3jvtk2BQzU/WPaWxF5aW8ELZAIS TaIGNaBva5wJG7URInhcWNW8I3BmadYohhxiNIOg= Date: Wed, 5 Aug 2020 12:43:28 -0500 From: Bjorn Helgaas To: Sean V Kelley Cc: bhelgaas@google.com, Jonathan.Cameron@huawei.com, rjw@rjwysocki.net, ashok.raj@intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Qiuxu Zhuo Subject: Re: [PATCH V2 2/9] PCI: Extend Root Port Driver to support RCEC Message-ID: <20200805174328.GA521293@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200804194052.193272-3-sean.v.kelley@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "git log --oneline" again. On Tue, Aug 04, 2020 at 12:40:45PM -0700, Sean V Kelley wrote: > From: Qiuxu Zhuo > > If a Root Complex Integrated Endpoint (RCiEP) is implemented, errors may > optionally be sent to a corresponding Root Complex Event Collector (RCEC). > Each RCiEP must be associated with no more than one RCEC. Interface errors > are reported to the OS by RCECs. > > For an RCEC (technically not a Bridge), error messages "received" from > associated RCiEPs must be enabled for "transmission" in order to cause a > System Error via the Root Control register or (when the Advanced Error > Reporting Capability is present) reporting via the Root Error Command > register and logging in the Root Error Status register and Error Source > Identification register. > > Given the commonality with Root Ports and the need to also support AER > and PME services for RCECs, extend the Root Port driver to support RCEC > devices through the addition of the RCEC Class ID to the driver > structure. > > Co-developed-by: Sean V Kelley > Signed-off-by: Qiuxu Zhuo > Signed-off-by: Sean V Kelley > --- > drivers/pci/pcie/portdrv_core.c | 8 ++++---- > drivers/pci/pcie/portdrv_pci.c | 5 ++++- > 2 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c > index 50a9522ab07d..5d4a400094fc 100644 > --- a/drivers/pci/pcie/portdrv_core.c > +++ b/drivers/pci/pcie/portdrv_core.c > @@ -234,11 +234,11 @@ static int get_port_device_capability(struct pci_dev *dev) > #endif > > /* > - * Root ports are capable of generating PME too. Root Complex > - * Event Collectors can also generate PMEs, but we don't handle > - * those yet. > + * Root ports and Root Complex Event Collectors are capable > + * of generating PME too. > */ > - if (pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT && > + if ((pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT || > + pci_pcie_type(dev) == PCI_EXP_TYPE_RC_EC) && > (pcie_ports_native || host->native_pme)) { > services |= PCIE_PORT_SERVICE_PME; > > diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c > index 3a3ce40ae1ab..4d880679b9b1 100644 > --- a/drivers/pci/pcie/portdrv_pci.c > +++ b/drivers/pci/pcie/portdrv_pci.c > @@ -106,7 +106,8 @@ static int pcie_portdrv_probe(struct pci_dev *dev, > if (!pci_is_pcie(dev) || > ((pci_pcie_type(dev) != PCI_EXP_TYPE_ROOT_PORT) && > (pci_pcie_type(dev) != PCI_EXP_TYPE_UPSTREAM) && > - (pci_pcie_type(dev) != PCI_EXP_TYPE_DOWNSTREAM))) > + (pci_pcie_type(dev) != PCI_EXP_TYPE_DOWNSTREAM) && > + (pci_pcie_type(dev) != PCI_EXP_TYPE_RC_EC))) > return -ENODEV; > > status = pcie_port_device_register(dev); > @@ -195,6 +196,8 @@ static const struct pci_device_id port_pci_ids[] = { > { PCI_DEVICE_CLASS(((PCI_CLASS_BRIDGE_PCI << 8) | 0x00), ~0) }, > /* subtractive decode PCI-to-PCI bridge, class type is 060401h */ > { PCI_DEVICE_CLASS(((PCI_CLASS_BRIDGE_PCI << 8) | 0x01), ~0) }, > + /* handle any Root Complex Event Collector */ > + { PCI_DEVICE_CLASS(((PCI_CLASS_SYSTEM_RCEC << 8) | 0x00), ~0) }, > { }, > }; > > -- > 2.27.0 >