From: Jorge Ramirez-Ortiz <jorge@foundries.io>
To: jorge@foundries.io, sumit.garg@linaro.org, jens.wiklander@linaro.org
Cc: mpm@selenic.com, herbert@gondor.apana.org.au, arnd@arndb.de,
ricardo@foundries.io, mike@foundries.io,
gregkh@linuxfoundation.org, op-tee@lists.trustedfirmware.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCHv3 1/2] hwrng: optee: handle unlimited data rates
Date: Thu, 6 Aug 2020 12:00:09 +0200 [thread overview]
Message-ID: <20200806100010.20509-1-jorge@foundries.io> (raw)
Data rates of MAX_UINT32 will schedule an unnecessary one jiffy
timeout on the call to msleep. Avoid this scenario by using 0 as the
unlimited data rate.
Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
---
drivers/char/hw_random/optee-rng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/optee-rng.c b/drivers/char/hw_random/optee-rng.c
index 49b2e02537dd..5bc4700c4dae 100644
--- a/drivers/char/hw_random/optee-rng.c
+++ b/drivers/char/hw_random/optee-rng.c
@@ -128,7 +128,7 @@ static int optee_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait)
data += rng_size;
read += rng_size;
- if (wait) {
+ if (wait && pvt_data->data_rate) {
if (timeout-- == 0)
return read;
msleep((1000 * (max - read)) / pvt_data->data_rate);
--
2.17.1
next reply other threads:[~2020-08-06 11:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 10:00 Jorge Ramirez-Ortiz [this message]
2020-08-06 10:00 ` [PATCHv3 2/2] hwrng: optee: fix wait use case Jorge Ramirez-Ortiz
2020-08-21 7:57 ` [PATCHv3 1/2] hwrng: optee: handle unlimited data rates Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806100010.20509-1-jorge@foundries.io \
--to=jorge@foundries.io \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jens.wiklander@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@foundries.io \
--cc=mpm@selenic.com \
--cc=op-tee@lists.trustedfirmware.org \
--cc=ricardo@foundries.io \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®