From: Mark Brown <broonie@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: pwm: Do not print error on probe deferral
Date: Thu, 6 Aug 2020 17:15:57 +0100 [thread overview]
Message-ID: <20200806161557.GD6442@sirena.org.uk> (raw)
In-Reply-To: <20200806155515.3936329-1-thierry.reding@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
On Thu, Aug 06, 2020 at 05:55:15PM +0200, Thierry Reding wrote:
> if (IS_ERR(drvdata->enb_gpio)) {
> ret = PTR_ERR(drvdata->enb_gpio);
> - dev_err(&pdev->dev, "Failed to get enable GPIO: %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Failed to get enable GPIO: %d\n", ret);
This will not provide any diagnostics if there's an issue with probe
deferral it'll be hard for people to figure out what's going on. At
most lower the severity to dev_dbg() but don't totally remove the
logging.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-08-06 17:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 15:55 Thierry Reding
2020-08-06 16:15 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806161557.GD6442@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®