From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: kernel test robot <lkp@intel.com>
Cc: Johnny Chuang <johnny.chuang@emc.com.tw>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Peter Hutterer <peter.hutterer@who-t.net>
Subject: Re: drivers/input/touchscreen/elants_i2c.c:859:45: warning: Clarify calculation precedence for '&' and
Date: Thu, 6 Aug 2020 15:31:05 -0700 [thread overview]
Message-ID: <20200806223105.GJ1665100@dtor-ws> (raw)
In-Reply-To: <202008020615.7WF7Tnj9%lkp@intel.com>
On Sun, Aug 02, 2020 at 06:18:19AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: d52daa8620c65960e1ef882adc1f92061326bd7a
> commit: f27ad8932725f8dd0cd1a46763de4a40377b1ae6 Input: elants_i2c - support palm detection
> date: 4 months ago
> compiler: xtensa-linux-gcc (GCC) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
>
> cppcheck warnings: (new ones prefixed by >>)
>
> >> drivers/input/touchscreen/elants_i2c.c:859:45: warning: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
> tool_type = buf[FW_POS_TOOL_TYPE] & BIT(0) ?
> ^
No, there is no need to clarify precedence as it is already clear.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2020-08-06 22:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 22:18 kernel test robot
2020-08-06 22:31 ` Dmitry Torokhov [this message]
2020-08-11 0:27 ` [kbuild-all] " Xia, Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806223105.GJ1665100@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=johnny.chuang@emc.com.tw \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=peter.hutterer@who-t.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®