From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FD24C433DF for ; Fri, 7 Aug 2020 13:16:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 636432075D for ; Fri, 7 Aug 2020 13:16:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726233AbgHGNQL (ORCPT ); Fri, 7 Aug 2020 09:16:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbgHGNQH (ORCPT ); Fri, 7 Aug 2020 09:16:07 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D6E5C061574 for ; Fri, 7 Aug 2020 06:16:07 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k42Dz-0003Po-KX; Fri, 07 Aug 2020 15:15:55 +0200 Received: from ore by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1k42Dw-0001e1-OG; Fri, 07 Aug 2020 15:15:52 +0200 Date: Fri, 7 Aug 2020 15:15:52 +0200 From: Oleksij Rempel To: Zhang Changzhong Cc: robin@protonic.nl, linux@rempel-privat.de, kernel@pengutronix.de, socketcan@hartkopp.net, mkl@pengutronix.de, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org Subject: Re: [PATCH net 0/4] support multipacket broadcast message Message-ID: <20200807131552.4hsuafdubumvh3hl@pengutronix.de> References: <1596599425-5534-1-git-send-email-zhangchangzhong@huawei.com> <20200806161027.py5ged3a23xpmxgi@pengutronix.de> <24c3daa5-8243-0b80-9f4c-aa5883cb75da@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="n75w4eckvcy5gpqk" Content-Disposition: inline In-Reply-To: <24c3daa5-8243-0b80-9f4c-aa5883cb75da@huawei.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 15:06:45 up 266 days, 4:25, 254 users, load average: 0.02, 0.05, 0.01 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --n75w4eckvcy5gpqk Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 07, 2020 at 05:36:38PM +0800, Zhang Changzhong wrote: > Hi Oleksij, >=20 > We have tested this j1939 stack according to SAE J1939-21. It works fine = for > most cases, but when we test multipacket broadcast message function we fo= und > the receiver can't receive those packets. >=20 > You can reproduce on CAN bus or vcan, for vcan case use cangw to connect = vcan0 > and vcan1: > sudo cangw -A -s vcan0 -d vcan1 -e > sudo cangw -A -s vcan1 -d vcan0 -e >=20 > To reproduce it use following commands: > testj1939 -B -r vcan1:0x90 & > testj1939 -B -s20 vcan0:0x80 :,0x12300 >=20 > Besides, candump receives correct packets while testj1939 receives nothin= g. Ok, thank you! i'm able to reproduce it and added following test: https://github.com/linux-can/can-tests/blob/master/j1939/j1939_ac_1k_bam_lo= cal0.sh --=20 Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --n75w4eckvcy5gpqk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEERBNZvwSgvmcMY/T74omh9DUaUbMFAl8tU/4ACgkQ4omh9DUa UbPhvxAAxOQ+jcN0KCTwuokh3OstfcYfo1QPKj+HKdphdxy7m6eA84SX1879VOiE zqJuqho7+jn5Cu7iReznWsHurGje9AB/pu3sDdKjk28DWDtbsen9+hooAOd7hKwZ ooxjUy2LSf0P6kWOvpboybb5/4D3VFw3lwmyIPZUsrtLhO5wEPCKlE/WQvn91y5x HQDixiG/ywyE321uKhjeLwTqA20Ub9ZWV6zN3TJYerjFpU5/jYxvlEjX854RNbXS gyiyM4mQUAQaGCB3zy3SFb22Kf+hZ0Ob7+jwgDiZfAeeVZMjrYjh5H4jlazqKhbX eeWtTUi3B99lrDK/sQEToi5CYvHa/5mYTwJLDyj0VKl+TqDB5hceM4Is23lvosho PQ8ZiP7ArK7s7fn1fscVTgLmatG7/ERuUmJYQiOXwWmIFnu0qwZ+kxpN6lDPS0Kf V93XapZBO+CB8Q50pGltMLpzGe40HGGlYEKLy9d1FQCS6xw8d1tpwfBpdbemPhaY F1aj3V1VYRe6a5qJQyZpeV6CpGiKEtU3mBoEkrDCu5DERFt8/RlFcKBKLb+OrjoI jC5kX9NKD6D1522yIuV2fIRX/6Fda9L1ZrwLqTbXfvcIuf/8crXlpNOLwGoINSje Tl7lC1QNWHYRo66WLEomLtTyZWRCaUawYsG7sGOQKM6msojpyX0= =RooE -----END PGP SIGNATURE----- --n75w4eckvcy5gpqk--