From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B557C433DF for ; Fri, 7 Aug 2020 13:28:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AFE62086A for ; Fri, 7 Aug 2020 13:28:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596806889; bh=cauRTF3cdR/PFgrsmHkzjr279ml8ZN/267S96A1D070=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=LYBICirtxx0FvtiXlJ9pwOOz2lxH43IyvpEGPqERNmYJaiorQAtJReC988iefZsqF NsYEeXO1l8O8Kmd+LLpmLLgsvD1symi4p6+uQ6rV2wPPFzhoVQXfk5M5R0QS4KCRM0 b6yh40htBRIjp6ExdDbDV/Vo9GltsanOjrbMYI6I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726126AbgHGN15 (ORCPT ); Fri, 7 Aug 2020 09:27:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:50598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726015AbgHGN1r (ORCPT ); Fri, 7 Aug 2020 09:27:47 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 771D12086A; Fri, 7 Aug 2020 13:27:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596806867; bh=cauRTF3cdR/PFgrsmHkzjr279ml8ZN/267S96A1D070=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aBXsGfYbdXLESB4THwag+WPAVnL5mwYabZopJFRadh5IwTbV4OJ5YuQUZpprZ3CC6 bp5X4FM9FzAK5ruMBje7aHEMQRi4UGr1Zwrdl/k+wEInPd2Z6/7BUoIJLBqrLxbuZb S3wmrfHiLijtUeSy2UjsqgR4FyGcBNUjf5tSXAVA= Date: Fri, 7 Aug 2020 14:27:22 +0100 From: Mark Brown To: Alain Volmat Cc: amelie.delaunay@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, fabrice.gasnier@st.com Subject: Re: [PATCH 2/5] spi: stm32: fix fifo threshold level in case of short transfer Message-ID: <20200807132722.GJ5435@sirena.org.uk> References: <1596806485-3810-1-git-send-email-alain.volmat@st.com> <1596806485-3810-3-git-send-email-alain.volmat@st.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AXxEqdD4tcVTjWte" Content-Disposition: inline In-Reply-To: <1596806485-3810-3-git-send-email-alain.volmat@st.com> X-Cookie: Disposable, use only once. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --AXxEqdD4tcVTjWte Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 07, 2020 at 03:21:22PM +0200, Alain Volmat wrote: > + /* data_packet should not exceed transfer length */ > + packet = (half_fifo > xfer_len) ? xfer_len : half_fifo; Please write normal conditional statements to improve legibility. --AXxEqdD4tcVTjWte Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8tVrkACgkQJNaLcl1U h9AKZQf/a+Ru7h5ixAXVScXCOGiC+r341yYUTHK9LElaCpXw4iTXlGHMRiJkJOsr adMT9NNEs2Ka5PQ7wiKIw558VLZ5WbCQ2paWcKN4vElYOhulMCRn3X7Lcs6VYzW1 scWxT07YTt15Tvxi7uBpRedIgOYUO/1sey+1skdwaqQbQYykoV/XUvRYehzyeZ7G tFJMFskTaBJ8T2I910IItEFasKttZUrLa1X3xtn97WiM2wnX+YCu+BDPwsKv5x0V 63H0dHkTGwEnNiByRU4O3rL8Bx0XnopWzYJlfSY+ayH0QYmh5raD0Fgn/86cW4e4 BVP46YZ6w0ZmTKL/prjveFSWY6zLyQ== =v0uW -----END PGP SIGNATURE----- --AXxEqdD4tcVTjWte--