From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEC95C433E0 for ; Fri, 7 Aug 2020 23:22:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A51532086A for ; Fri, 7 Aug 2020 23:22:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=melexis.com header.i=@melexis.com header.b="ARlbCnCA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726316AbgHGXV7 (ORCPT ); Fri, 7 Aug 2020 19:21:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726096AbgHGXV6 (ORCPT ); Fri, 7 Aug 2020 19:21:58 -0400 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFC81C061757 for ; Fri, 7 Aug 2020 16:21:56 -0700 (PDT) Received: by mail-ed1-x543.google.com with SMTP id v22so2387564edy.0 for ; Fri, 07 Aug 2020 16:21:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=melexis.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WzDswwBfXvOnych9mKo86pvZBTTMjA75hoRZ23jMux8=; b=ARlbCnCAReWvHkvrUcB0+effjhlObIgwsFI9tzxNGhL/ZSDNxYifZIq9H1kafIQph8 B31tujSpH34tRhoYvtIvAsLjsiZ+Mc6Ac+2AqXJ3n6HCKwfatrShXqBcF2qBMofWaY8u Vr7I593mVLi0qTTY8eCP2ImTFOv3IfH35GcmvudurNQS1tNyTXJD+vhDPnpn8VWpLXbY huR5ATnV7q8mKwekkAs+RxUtFpyFVGdnYuzL4OXg358ceABnh7LGi2sgrlRsMoMaXfF9 YWteGmr6lUozQl5ZTQ2omka04OY0K5NdaaP2gmiPO5obgnr+IWp+iNHDd4psHnTNbxeN 7JCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WzDswwBfXvOnych9mKo86pvZBTTMjA75hoRZ23jMux8=; b=K7ghsr3vCSMiaGQHDJNgUx3gKrOjDtz9NcL04aIrkGK4K+W1XMey0nFvzelbLblSFG JHmt0OW3b6S4uEpKlkKVRH8ycYfm6CMdMtqlR7nhidQpVUqhDbfZ3jG8eOhahT2d3j8t rwCQ6Zua3VSD9JlB4l8TitYC5ZsTiT+GyELqbWw85BFKIqU1ek6TQCsl0Xp7oIOUO0wQ hFPLzqSV0ggVydPlPwIUIeWMnIHKW9yKGcybUvFEDlXP4H+shU2Y36sHRIzPeFw1r1Kl PVH0olfIfbnq0rnuWqJig3V70tJtBtDCCJGb29lYxtexheAxVrSJD5MBCvsVee+/IsKV 6JDw== X-Gm-Message-State: AOAM530qgHORPF36odLKObOBmlQ4bS49x1FrwK1GKuaX+sDswd5I2xUH ZXXGs3shWt/EIl0ZK8MZkWa5Zg== X-Google-Smtp-Source: ABdhPJxOzFPkzRbFazxGU9ryBNmQ8aLnpG80WbsKp2DM6lv+b9O7HITKlCWK7MJMBdsAqhaKQTeXSA== X-Received: by 2002:a50:ee96:: with SMTP id f22mr10644132edr.243.1596842515514; Fri, 07 Aug 2020 16:21:55 -0700 (PDT) Received: from localhost.localdomain (ptr-4xajgywt9p1tstfsdfc.18120a2.ip6.access.telenet.be. [2a02:1810:a421:dd00:b0e6:1cd9:30c1:35f8]) by smtp.gmail.com with ESMTPSA id y9sm6305574edt.34.2020.08.07.16.21.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 16:21:54 -0700 (PDT) From: Crt Mori To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Crt Mori Subject: [PATCH v3 1/2] iio:temperature:mlx90632: Reduce number of equal calulcations Date: Sat, 8 Aug 2020 01:21:03 +0200 Message-Id: <20200807232104.1256119-2-cmo@melexis.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200807232104.1256119-1-cmo@melexis.com> References: <20200807232104.1256119-1-cmo@melexis.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org TAdut4 was calculated each iteration although it did not change. In light of near future additions of the Extended range DSP calculations, this function refactoring will help reduce unrelated changes in that series as well as reduce the number of new functions needed. Signed-off-by: Crt Mori --- drivers/iio/temperature/mlx90632.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c index 51b812bcff2e..763a148a0095 100644 --- a/drivers/iio/temperature/mlx90632.c +++ b/drivers/iio/temperature/mlx90632.c @@ -374,11 +374,11 @@ static s32 mlx90632_calc_temp_ambient(s16 ambient_new_raw, s16 ambient_old_raw, } static s32 mlx90632_calc_temp_object_iteration(s32 prev_object_temp, s64 object, - s64 TAdut, s32 Fa, s32 Fb, + s64 TAdut, s64 TAdut4, s32 Fa, s32 Fb, s32 Ga, s16 Ha, s16 Hb, u16 emissivity) { - s64 calcedKsTO, calcedKsTA, ir_Alpha, TAdut4, Alpha_corr; + s64 calcedKsTO, calcedKsTA, ir_Alpha, Alpha_corr; s64 Ha_customer, Hb_customer; Ha_customer = ((s64)Ha * 1000000LL) >> 14ULL; @@ -393,10 +393,6 @@ static s32 mlx90632_calc_temp_object_iteration(s32 prev_object_temp, s64 object, Alpha_corr = emissivity * div64_s64(Alpha_corr, 100000LL); Alpha_corr = div64_s64(Alpha_corr, 1000LL); ir_Alpha = div64_s64((s64)object * 10000000LL, Alpha_corr); - TAdut4 = (div64_s64(TAdut, 10000LL) + 27315) * - (div64_s64(TAdut, 10000LL) + 27315) * - (div64_s64(TAdut, 10000LL) + 27315) * - (div64_s64(TAdut, 10000LL) + 27315); return (int_sqrt64(int_sqrt64(ir_Alpha * 1000000000000LL + TAdut4)) - 27315 - Hb_customer) * 10; @@ -406,17 +402,21 @@ static s32 mlx90632_calc_temp_object(s64 object, s64 ambient, s32 Ea, s32 Eb, s32 Fa, s32 Fb, s32 Ga, s16 Ha, s16 Hb, u16 tmp_emi) { - s64 kTA, kTA0, TAdut; + s64 kTA, kTA0, TAdut, TAdut4; s64 temp = 25000; s8 i; kTA = (Ea * 1000LL) >> 16LL; kTA0 = (Eb * 1000LL) >> 8LL; TAdut = div64_s64(((ambient - kTA0) * 1000000LL), kTA) + 25 * 1000000LL; + TAdut4 = (div64_s64(TAdut, 10000LL) + 27315) * + (div64_s64(TAdut, 10000LL) + 27315) * + (div64_s64(TAdut, 10000LL) + 27315) * + (div64_s64(TAdut, 10000LL) + 27315); /* Iterations of calculation as described in datasheet */ for (i = 0; i < 5; ++i) { - temp = mlx90632_calc_temp_object_iteration(temp, object, TAdut, + temp = mlx90632_calc_temp_object_iteration(temp, object, TAdut, TAdut4, Fa, Fb, Ga, Ha, Hb, tmp_emi); } -- 2.25.1