mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Wright Feng <wright.feng@cypress.com>,
	Chi-hsien Lin <chi-hsien.lin@cypress.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	Sasha Levin <sashal@kernel.org>,
	linux-wireless@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com,
	brcm80211-dev-list@cypress.com, netdev@vger.kernel.org
Subject: [PATCH AUTOSEL 4.19 19/31] brcmfmac: keep SDIO watchdog running when console_interval is non-zero
Date: Mon, 10 Aug 2020 15:12:47 -0400	[thread overview]
Message-ID: <20200810191259.3794858-19-sashal@kernel.org> (raw)
In-Reply-To: <20200810191259.3794858-1-sashal@kernel.org>

From: Wright Feng <wright.feng@cypress.com>

[ Upstream commit eccbf46b15bb3e35d004148f7c3a8fa8e9b26c1e ]

brcmfmac host driver makes SDIO bus sleep and stops SDIO watchdog if no
pending event or data. As a result, host driver does not poll firmware
console buffer before buffer overflow, which leads to missing firmware
logs. We should not stop SDIO watchdog if console_interval is non-zero
in debug build.

Signed-off-by: Wright Feng <wright.feng@cypress.com>
Signed-off-by: Chi-hsien Lin <chi-hsien.lin@cypress.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200604071835.3842-4-wright.feng@cypress.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
index 96870d1b3b73b..a5195bdb4d9bd 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
@@ -3633,7 +3633,11 @@ static void brcmf_sdio_bus_watchdog(struct brcmf_sdio *bus)
 			if (bus->idlecount > bus->idletime) {
 				brcmf_dbg(SDIO, "idle\n");
 				sdio_claim_host(bus->sdiodev->func1);
-				brcmf_sdio_wd_timer(bus, false);
+#ifdef DEBUG
+				if (!BRCMF_FWCON_ON() ||
+				    bus->console_interval == 0)
+#endif
+					brcmf_sdio_wd_timer(bus, false);
 				bus->idlecount = 0;
 				brcmf_sdio_bus_sleep(bus, true, false);
 				sdio_release_host(bus->sdiodev->func1);
-- 
2.25.1


  parent reply	other threads:[~2020-08-10 19:21 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-10 19:12 [PATCH AUTOSEL 4.19 01/31] drm/tilcdc: fix leak & null ref in panel_connector_get_modes Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 02/31] soc: qcom: rpmh-rsc: Set suppress_bind_attrs flag Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 03/31] Bluetooth: add a mutex lock to avoid UAF in do_enale_set Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 04/31] loop: be paranoid on exit and prevent new additions / removals Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 05/31] fs/btrfs: Add cond_resched() for try_release_extent_mapping() stalls Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 06/31] drm/amdgpu: avoid dereferencing a NULL pointer Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 07/31] drm/radeon: Fix reference count leaks caused by pm_runtime_get_sync Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 08/31] crypto: aesni - Fix build with LLVM_IAS=1 Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 09/31] video: fbdev: neofb: fix memory leak in neo_scan_monitor() Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 10/31] md-cluster: fix wild pointer of unlock_all_bitmaps() Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 11/31] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 DT binding Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 12/31] drm/etnaviv: fix ref count leak via pm_runtime_get_sync Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 13/31] drm/nouveau: fix multiple instances of reference count leaks Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 14/31] usb: mtu3: clear dual mode of u3port when disable device Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 15/31] drm/debugfs: fix plain echo to connector "force" attribute Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 16/31] drm/radeon: disable AGP by default Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 17/31] irqchip/irq-mtk-sysirq: Replace spinlock with raw_spinlock Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 18/31] mm/mmap.c: Add cond_resched() for exit_mmap() CPU stalls Sasha Levin
2020-08-10 19:12 ` Sasha Levin [this message]
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 20/31] brcmfmac: To fix Bss Info flag definition Bug Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 21/31] brcmfmac: set state of hanger slot to FREE when flushing PSQ Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 22/31] iwlegacy: Check the return value of pcie_capability_read_*() Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 23/31] gpu: host1x: debug: Fix multiple channels emitting messages simultaneously Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 24/31] usb: gadget: net2280: fix memory leak on probe error handling paths Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 25/31] bdc: Fix bug causing crash after multiple disconnects Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 26/31] usb: bdc: Halt controller on suspend Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 27/31] dyndbg: fix a BUG_ON in ddebug_describe_flags Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 28/31] dyndbg: prefer declarative init in caller, to memset in callee Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 29/31] bcache: fix super block seq numbers comparision in register_cache_set() Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 30/31] ACPICA: Do not increment operation_region reference counts for field units Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 31/31] drm/msm: ratelimit crtc event overflow error Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200810191259.3794858-19-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211-dev-list@cypress.com \
    --cc=chi-hsien.lin@cypress.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=wright.feng@cypress.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®