mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Felix Fietkau <nbd@nbd.name>
Subject: drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c:133 mt7615_reset_test_set() warn: inconsistent returns 'dev->mt76.mutex'.
Date: Thu, 13 Aug 2020 07:43:29 +0800	[thread overview]
Message-ID: <202008130726.UBeAuz8t%lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2810 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7c2a69f610e64c8dec6a06a66e721f4ce1dd783a
commit: ea4906c4be4944f8341d500f83267d1ba3e8e838 mt76: mt7615: wake device before accessing regmap in debugfs
date:   3 weeks ago
config: parisc-randconfig-m031-20200811 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

smatch warnings:
drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c:133 mt7615_reset_test_set() warn: inconsistent returns 'dev->mt76.mutex'.

vim +133 drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c

f347f81a8ac98b Felix Fietkau    2019-12-29  109  
f347f81a8ac98b Felix Fietkau    2019-12-29  110  DEFINE_DEBUGFS_ATTRIBUTE(fops_fw_debug, mt7615_fw_debug_get,
f347f81a8ac98b Felix Fietkau    2019-12-29  111  			 mt7615_fw_debug_set, "%lld\n");
f347f81a8ac98b Felix Fietkau    2019-12-29  112  
35492cd28f2a06 Felix Fietkau    2020-01-31  113  static int
35492cd28f2a06 Felix Fietkau    2020-01-31  114  mt7615_reset_test_set(void *data, u64 val)
35492cd28f2a06 Felix Fietkau    2020-01-31  115  {
35492cd28f2a06 Felix Fietkau    2020-01-31  116  	struct mt7615_dev *dev = data;
35492cd28f2a06 Felix Fietkau    2020-01-31  117  	struct sk_buff *skb;
35492cd28f2a06 Felix Fietkau    2020-01-31  118  
35492cd28f2a06 Felix Fietkau    2020-01-31  119  	if (!mt7615_wait_for_mcu_init(dev))
35492cd28f2a06 Felix Fietkau    2020-01-31  120  		return 0;
35492cd28f2a06 Felix Fietkau    2020-01-31  121  
ea4906c4be4944 Lorenzo Bianconi 2020-07-03  122  	mt7615_mutex_acquire(dev);
ea4906c4be4944 Lorenzo Bianconi 2020-07-03  123  
35492cd28f2a06 Felix Fietkau    2020-01-31  124  	skb = alloc_skb(1, GFP_KERNEL);
35492cd28f2a06 Felix Fietkau    2020-01-31  125  	if (!skb)
35492cd28f2a06 Felix Fietkau    2020-01-31  126  		return -ENOMEM;
35492cd28f2a06 Felix Fietkau    2020-01-31  127  
35492cd28f2a06 Felix Fietkau    2020-01-31  128  	skb_put(skb, 1);
35492cd28f2a06 Felix Fietkau    2020-01-31  129  	mt76_tx_queue_skb_raw(dev, 0, skb, 0);
35492cd28f2a06 Felix Fietkau    2020-01-31  130  
ea4906c4be4944 Lorenzo Bianconi 2020-07-03  131  	mt7615_mutex_release(dev);
ea4906c4be4944 Lorenzo Bianconi 2020-07-03  132  
35492cd28f2a06 Felix Fietkau    2020-01-31 @133  	return 0;
35492cd28f2a06 Felix Fietkau    2020-01-31  134  }
35492cd28f2a06 Felix Fietkau    2020-01-31  135  

:::::: The code at line 133 was first introduced by commit
:::::: 35492cd28f2a06623279a61955539fa6c5ae6067 mt76: mt7615: add support for testing hardware reset

:::::: TO: Felix Fietkau <nbd@nbd.name>
:::::: CC: Felix Fietkau <nbd@nbd.name>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30912 bytes --]

                 reply	other threads:[~2020-08-12 23:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202008130726.UBeAuz8t%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®