From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF357C433E3 for ; Thu, 13 Aug 2020 20:14:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2AF520829 for ; Thu, 13 Aug 2020 20:14:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597349676; bh=hGkSuc10QjCyDoZEHEmNWkXKjIZx24dgsOUsDjIFXac=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=yjahFU4SpBXrMjKNlJUr+62VBBsl2XlRkfqCpM0cBlkIHVw0Ice2Wyo4JUJinoiDu 74QeFratMdFw8Qippx4/H6zYv/SvJaaOdXdCNVmi5aoPEBPTCJ3lW6tiWq/z/dlBRO McfA3foIqQPPoF+eWwOAleLj9OZykJ8VRnW4Cdqc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726576AbgHMUOe (ORCPT ); Thu, 13 Aug 2020 16:14:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:55700 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726312AbgHMUOe (ORCPT ); Thu, 13 Aug 2020 16:14:34 -0400 Received: from localhost (104.sub-72-107-126.myvzw.com [72.107.126.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 756FE20675; Thu, 13 Aug 2020 20:14:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597349673; bh=hGkSuc10QjCyDoZEHEmNWkXKjIZx24dgsOUsDjIFXac=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=BChaOOfNuZg5/4N1BNXB+Z99vuLu0ZszO2nk00pSmSPJ0tcwq3tJgDn4gXnFJffRN 48H3yKKRUjd+b/HN6D2PZnKzzvEI6SDSWTvYG21n2eu4OLdoRMtr90gelFozvs1rrV b3I34kpeXcXMZ0uB9utsG7UGQVqJ9ZgqecjLlrLU= Date: Thu, 13 Aug 2020 15:14:32 -0500 From: Bjorn Helgaas To: Randy Dunlap Cc: LKML , linux-pci , Bjorn Helgaas , jsbarnes@google.com, Arjan van de Ven , Len Brown , Jacob Pan , Andy Shevchenko Subject: Re: [PATCH] x86/pci: fix intel_mid_pci.c build error when ACPI is not enabled Message-ID: <20200813201432.GA1185885@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20952e3e-6b06-11e4-aff7-07dfbdc5ee18@infradead.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+cc Andy] On Thu, Aug 13, 2020 at 12:58:38PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build error when CONFIG_ACPI is not set/enabled by adding > the header file which contains a stub for the function > in the build error. > > ../arch/x86/pci/intel_mid_pci.c: In function ‘intel_mid_pci_init’: > ../arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration] > acpi_noirq_set(); Fixes: a912a7584ec3 ("x86/platform/intel-mid: Move PCI initialization to arch_init()") Possibly Cc: stable@vger.kernel.org # v4.16+ > Signed-off-by: Randy Dunlap > Cc: Jacob Pan > Cc: Len Brown > Cc: Bjorn Helgaas > Cc: Jesse Barnes > Cc: Arjan van de Ven > Cc: linux-pci@vger.kernel.org > --- > Found in linux-next, but applies to/exists in mainline also. > > Alternative.1: X86_INTEL_MID depends on ACPI > Alternative.2: drop X86_INTEL_MID support > > arch/x86/pci/intel_mid_pci.c | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20200813.orig/arch/x86/pci/intel_mid_pci.c > +++ linux-next-20200813/arch/x86/pci/intel_mid_pci.c > @@ -33,6 +33,7 @@ > #include > #include > #include > +#include > > #define PCIE_CAP_OFFSET 0x100 > >