From: Sakari Ailus <sakari.ailus@iki.fi>
To: Jacopo Mondi <jacopo@jmondi.org>
Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Steve Longerbeam <slongerbeam@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Maxime Ripard <maxime@cerno.tech>,
Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCH] media: ov5640: Correct Bit Div register in clock tree diagram
Date: Fri, 14 Aug 2020 00:51:18 +0300 [thread overview]
Message-ID: <20200813215117.GI840@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20200805125113.rhrhy6j6uccv3jmz@uno.localdomain>
On Wed, Aug 05, 2020 at 02:51:13PM +0200, Jacopo Mondi wrote:
> Hi Paul,
>
> On Mon, Aug 03, 2020 at 11:06:58AM +0200, Paul Kocialkowski wrote:
> > Although the code is correct and doing the right thing, the clock diagram
> > showed the wrong register for the bit divider, which had me doubting the
> > understanding of the tree. Fix this to avoid doubts in the future.
>
> Thanks for spotting this! Correct indeed!
>
> I'm not sure it's worth a fixes tag, but just in case:
> Fixes: aa2882481cada ("media: ov5640: Adjust the clock based on the expected rate")
Added that.
>
>
> Acked-by: Jacopo Mondi <jacopo@jmondi.org>
Thanks, Paul and Jacopo!
--
Sakari Ailus
prev parent reply other threads:[~2020-08-13 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 9:06 Paul Kocialkowski
2020-08-05 12:51 ` Jacopo Mondi
2020-08-13 21:51 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813215117.GI840@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=hverkuil@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=mchehab@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®