From: Dave Young <dyoung@redhat.com>
To: Youling Tang <tangyouling@loongson.cn>
Cc: Eric Biederman <ebiederm@xmission.com>,
Vivek Goyal <vgoyal@redhat.com>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] kexec: Delete an unnecessary comparison
Date: Fri, 14 Aug 2020 13:51:19 +0800 [thread overview]
Message-ID: <20200814055119.GA17263@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <1597322730-3881-1-git-send-email-tangyouling@loongson.cn>
On 08/13/20 at 08:45pm, Youling Tang wrote:
> Regardless of whether the ret value is zero or non-zero, the trajectory
> of the program execution is the same, so there is no need to compare.
>
> Signed-off-by: Youling Tang <tangyouling@loongson.cn>
> ---
> kernel/kexec_file.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
> index 78c0837..3ad0ae2 100644
> --- a/kernel/kexec_file.c
> +++ b/kernel/kexec_file.c
> @@ -800,8 +800,6 @@ static int kexec_calculate_store_digests(struct kimage *image)
>
> ret = kexec_purgatory_get_set_symbol(image, "purgatory_sha256_digest",
> digest, SHA256_DIGEST_SIZE, 0);
> - if (ret)
> - goto out_free_digest;
> }
>
> out_free_digest:
> --
> 2.1.0
>
Acked-by: Dave Young <dyoung@redhat.com>
Thanks
Dave
next prev parent reply other threads:[~2020-08-14 5:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 12:45 Youling Tang
2020-08-14 5:51 ` Dave Young [this message]
2020-08-14 6:07 ` Joe Perches
2020-08-14 10:11 ` Youling Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814055119.GA17263@dhcp-128-65.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangyouling@loongson.cn \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®