From: Christoph Hellwig <hch@lst.de>
To: Tong Zhang <ztong0001@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me
Subject: Re: [PATCH] nvme-pci: cancel nvme device request before disabling
Date: Fri, 14 Aug 2020 10:16:47 +0200 [thread overview]
Message-ID: <20200814081647.GA10347@lst.de> (raw)
In-Reply-To: <20200814071431.201400-1-ztong0001@gmail.com>
On Fri, Aug 14, 2020 at 03:14:31AM -0400, Tong Zhang wrote:
> This patch addresses an irq free warning and null pointer dereference
> error problem when nvme devices got timeout error during initialization.
> This problem happens when nvme_timeout() function is called while
> nvme_reset_work() is still in execution. This patch fixed the problem by
> setting flag of the problematic request to NVME_REQ_CANCELLED before
> calling nvme_dev_disable() to make sure __nvme_submit_sync_cmd() returns
> an error code and let nvme_submit_sync_cmd() fail gracefully.
> The following is console output.
The commit log looks a little weird due to the extra indentation.
The patch itself looks good, though:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-08-14 8:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 7:14 Tong Zhang
2020-08-14 8:16 ` Christoph Hellwig [this message]
2020-08-14 11:53 ` Tong Zhang
2020-08-14 11:46 ` [PATCH v2] " Tong Zhang
2020-08-14 15:04 ` [PATCH] " Keith Busch
2020-08-14 15:37 ` Tong Zhang
2020-08-14 15:42 ` Keith Busch
2020-08-14 16:11 ` Tong Zhang
2020-08-27 15:01 ` Keith Busch
2020-08-28 12:43 ` Tong Zhang
2020-08-28 14:17 ` [PATCH v2] " Tong Zhang
2020-08-28 15:51 ` Keith Busch
2020-08-28 15:56 ` Sagi Grimberg
2020-08-14 18:00 ` [PATCH] " Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814081647.GA10347@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=ztong0001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome