mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Stephen Kitt <steve@sk2.org>
Cc: Beniamin Bia <beniamin.bia@analog.com>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Jean Delvare <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/hwmon/adm1177.c: use simple i2c probe
Date: Fri, 14 Aug 2020 08:13:58 -0700	[thread overview]
Message-ID: <20200814151358.GA256451@roeck-us.net> (raw)
In-Reply-To: <20200813160958.1506536-1-steve@sk2.org>

On Thu, Aug 13, 2020 at 06:09:58PM +0200, Stephen Kitt wrote:
> This driver doesn't use the id information provided by the old i2c
> probe function, so it can trivially be converted to the simple
> ("probe_new") form.
> 
> Signed-off-by: Stephen Kitt <steve@sk2.org>

I'll apply the entire series, but please don't use entire path names
as tag in the future but follow bubsystem rules.

Thanks,
Guenter

> ---
>  drivers/hwmon/adm1177.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/adm1177.c b/drivers/hwmon/adm1177.c
> index d314223a404a..6e8bb661894b 100644
> --- a/drivers/hwmon/adm1177.c
> +++ b/drivers/hwmon/adm1177.c
> @@ -196,8 +196,7 @@ static void adm1177_remove(void *data)
>  	regulator_disable(st->reg);
>  }
>  
> -static int adm1177_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *id)
> +static int adm1177_probe(struct i2c_client *client)
>  {
>  	struct device *dev = &client->dev;
>  	struct device *hwmon_dev;
> @@ -277,7 +276,7 @@ static struct i2c_driver adm1177_driver = {
>  		.name = "adm1177",
>  		.of_match_table = adm1177_dt_ids,
>  	},
> -	.probe = adm1177_probe,
> +	.probe_new = adm1177_probe,
>  	.id_table = adm1177_id,
>  };
>  module_i2c_driver(adm1177_driver);

  reply	other threads:[~2020-08-14 15:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-13 16:09 Stephen Kitt
2020-08-14 15:13 ` Guenter Roeck [this message]
2020-08-21 11:25   ` Stephen Kitt
2020-08-21 15:55     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200814151358.GA256451@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Michael.Hennerich@analog.com \
    --cc=beniamin.bia@analog.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steve@sk2.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®