From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D768CC433E1 for ; Mon, 17 Aug 2020 18:46:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8890204EC for ; Mon, 17 Aug 2020 18:46:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391601AbgHQSqr (ORCPT ); Mon, 17 Aug 2020 14:46:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388043AbgHQSqm (ORCPT ); Mon, 17 Aug 2020 14:46:42 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FEDCC061389; Mon, 17 Aug 2020 11:46:41 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9F77014ACC17C; Mon, 17 Aug 2020 11:29:47 -0700 (PDT) Date: Mon, 17 Aug 2020 11:46:29 -0700 (PDT) Message-Id: <20200817.114629.1895503086750807628.davem@davemloft.net> To: rdunlap@infradead.org Cc: linux-kernel@vger.kernel.org, linux@armlinux.org.uk, netdev@vger.kernel.org Subject: Re: [PATCH] phylink: : fix function prototype kernel-doc warning From: David Miller In-Reply-To: References: <20200816222549.379-1-rdunlap@infradead.org> <20200816.211451.1874573780407600816.davem@davemloft.net> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 17 Aug 2020 11:29:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap Date: Sun, 16 Aug 2020 22:43:54 -0700 > On 8/16/20 9:14 PM, David Miller wrote: >> From: Randy Dunlap >> Date: Sun, 16 Aug 2020 15:25:49 -0700 >> >>> Fix a kernel-doc warning for the pcs_config() function prototype: >>> >>> ../include/linux/phylink.h:406: warning: Excess function parameter 'permit_pause_to_mac' description in 'pcs_config' >>> >>> Fixes: 7137e18f6f88 ("net: phylink: add struct phylink_pcs") >>> Signed-off-by: Randy Dunlap >> >> There's no definition of this function anywhere. Maybe just remove all of >> this? >> > > It's for documentation purposes... > > It's a "method" (callback) function. I see, that's an unfortunate shortcoming of kerneldoc. Applied, thanks.