From: Allen Pais <allen.lkml@gmail.com>
To: mchehab@kernel.org, maintainers@bluecherrydvr.com,
patrice.chotard@st.com
Cc: keescook@chromium.org, linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Allen Pais <allen.lkml@gmail.com>,
Romain Perier <romain.perier@gmail.com>
Subject: [PATCH 06/11] media: tw5864: convert tasklets to use new tasklet_setup() API
Date: Mon, 17 Aug 2020 14:01:48 +0530 [thread overview]
Message-ID: <20200817083153.22218-7-allen.lkml@gmail.com> (raw)
In-Reply-To: <20200817083153.22218-1-allen.lkml@gmail.com>
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier <romain.perier@gmail.com>
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
drivers/media/pci/tw5864/tw5864-video.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/media/pci/tw5864/tw5864-video.c b/drivers/media/pci/tw5864/tw5864-video.c
index ec1e06da7e4f..e232c6535a0a 100644
--- a/drivers/media/pci/tw5864/tw5864-video.c
+++ b/drivers/media/pci/tw5864/tw5864-video.c
@@ -175,7 +175,7 @@ static const unsigned int intra4x4_lambda3[] = {
static v4l2_std_id tw5864_get_v4l2_std(enum tw5864_vid_std std);
static enum tw5864_vid_std tw5864_from_v4l2_std(v4l2_std_id v4l2_std);
-static void tw5864_handle_frame_task(unsigned long data);
+static void tw5864_handle_frame_task(struct tasklet_struct *t);
static void tw5864_handle_frame(struct tw5864_h264_frame *frame);
static void tw5864_frame_interval_set(struct tw5864_input *input);
@@ -1057,8 +1057,7 @@ int tw5864_video_init(struct tw5864_dev *dev, int *video_nr)
dev->irqmask |= TW5864_INTR_VLC_DONE | TW5864_INTR_TIMER;
tw5864_irqmask_apply(dev);
- tasklet_init(&dev->tasklet, tw5864_handle_frame_task,
- (unsigned long)dev);
+ tasklet_setup(&dev->tasklet, tw5864_handle_frame_task);
for (i = 0; i < TW5864_INPUTS; i++) {
dev->inputs[i].root = dev;
@@ -1313,9 +1312,9 @@ static int tw5864_is_motion_triggered(struct tw5864_h264_frame *frame)
return detected;
}
-static void tw5864_handle_frame_task(unsigned long data)
+static void tw5864_handle_frame_task(struct tasklet_struct *t)
{
- struct tw5864_dev *dev = (struct tw5864_dev *)data;
+ struct tw5864_dev *dev = from_tasklet(dev, t, tasklet);
unsigned long flags;
int batch_size = H264_BUF_CNT;
--
2.17.1
next prev parent reply other threads:[~2020-08-17 8:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 8:31 [PATCH 00/11] media: convert tasklets to use new tasklet_setup() Allen Pais
2020-08-17 8:31 ` [PATCH 01/11] media: bt8xx: convert tasklets to use new tasklet_setup() API Allen Pais
2020-08-17 8:31 ` [PATCH 02/11] media: mantis: " Allen Pais
2020-08-17 8:31 ` [PATCH 03/11] media: ngene: " Allen Pais
2020-08-17 8:31 ` [PATCH 04/11] media: smipcie: " Allen Pais
2020-08-17 8:31 ` [PATCH 05/11] media: ttpci: " Allen Pais
2020-08-17 8:31 ` Allen Pais [this message]
2020-08-17 8:31 ` [PATCH 07/11] media: marvell-ccic: " Allen Pais
2020-08-17 8:31 ` [PATCH 08/11] media: pxa_camera: " Allen Pais
2020-08-17 8:31 ` [PATCH 09/11] media: sti: " Allen Pais
2020-08-17 8:31 ` [PATCH 10/11] media/radio: wl128x: " Allen Pais
2020-08-17 8:31 ` [PATCH 11/11] media: ttusb-dec: " Allen Pais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817083153.22218-7-allen.lkml@gmail.com \
--to=allen.lkml@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maintainers@bluecherrydvr.com \
--cc=mchehab@kernel.org \
--cc=patrice.chotard@st.com \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®