From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECC30C433E1 for ; Mon, 17 Aug 2020 19:29:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE66D204EC for ; Mon, 17 Aug 2020 19:29:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lfkmiNvf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732221AbgHQT2o (ORCPT ); Mon, 17 Aug 2020 15:28:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732190AbgHQT2P (ORCPT ); Mon, 17 Aug 2020 15:28:15 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5904EC061342 for ; Mon, 17 Aug 2020 12:28:15 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id f9so8123140pju.4 for ; Mon, 17 Aug 2020 12:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/K/jgK8f2b3gfIxZCz2aodMs51/j1UmWIbA0xQ4Rg4o=; b=lfkmiNvf7aWyMq4W/ABS66AbSGwPDK4/gSe7KpUo1u+V3ZDzJYaa4SZCJM35LFoSeq uypWUeCVnbtPuTlC6Lv32YnGX41etwb0Tro5sTqJv62MgvvHNClJfRyjsQ85Ou5LahfA L3x2mLvPon1Pa5RiuLmxjerV4ytCXX9sKlZ2A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/K/jgK8f2b3gfIxZCz2aodMs51/j1UmWIbA0xQ4Rg4o=; b=IRH7ii17nMoMbUywfh8pp1Od86qEN4e0PxeqSK7OyZuIQEaFsBvrFfWZBi4npd8VF/ YJ6iyZk4N2ZHFkcVfKMqw3akwwJDrQDKJW9QX9gCHTJtXM7I3EPy8hGOh1vRDgqELVic 1iZqlDqHQViB12VJMo1Ent+6G6cHwgW6bAhyV3Pffjy3lgHIJNozNIWLyB3QGM+bnj0n Ias9xRO0UL5QKHZJ2Xhuw+8Qljt5q5bNFo/Z+boh+TyNiCQNqt4z0a5WKbUUvrylZOY+ DPMUphFnXTs4/dQbJ3pdqjGpebYbLR/xULNNJw9uBd2wwh6A6DiLE8NEG8HygJYUEBK7 ImGg== X-Gm-Message-State: AOAM5329hiVsAXrlUbB8ASx1jgSHfAqGGXY88bGdTdyVtAnf+6jFDwbm 9NpbJK1kOYRE+4qHJh9CMpwKFA== X-Google-Smtp-Source: ABdhPJxQXWN+Ph7ND4lvHYfqN6PVhgPAKtkPfn8HjEia6Dm6hV0gw3K3eYh80/xzuqoQhRxCjmbyAw== X-Received: by 2002:a17:902:8210:: with SMTP id x16mr12901228pln.166.1597692494753; Mon, 17 Aug 2020 12:28:14 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id b25sm20700960pft.134.2020.08.17.12.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 12:28:13 -0700 (PDT) Date: Mon, 17 Aug 2020 12:28:11 -0700 From: Kees Cook To: James Bottomley Cc: Allen Pais , martin.petersen@oracle.com, kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com, linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, target-devel@vger.kernel.org, megaraidlinux.pdl@broadcom.com, Allen Pais Subject: Re: [PATCH 0/8] scsi: convert tasklets to use new tasklet_setup() Message-ID: <202008171227.D3A4F454D8@keescook> References: <20200817085409.25268-1-allen.cryptic@gmail.com> <1597675318.4475.11.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1597675318.4475.11.camel@linux.ibm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 17, 2020 at 07:41:58AM -0700, James Bottomley wrote: > On Mon, 2020-08-17 at 14:24 +0530, Allen Pais wrote: > > From: Allen Pais > > > > Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' > > introduced a new tasklet initialization API. This series converts > > all the scsi drivers to use the new tasklet_setup() API > > I've got to say I agree with Jens, this was a silly obfuscation: > > +#define from_tasklet(var, callback_tasklet, tasklet_fieldname) \ > + container_of(callback_tasklet, typeof(*var), tasklet_fieldname) > > Just use container_of directly since we all understand what it does. But then the lines get really long, wrapped, etc. This is what the timer_struct conversion did too (added a container_of wrapper), so I think it makes sense here too. -- Kees Cook