mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Xu Wang <vulab@iscas.ac.cn>,
	jaharkes@cs.cmu.edu, coda@cs.cmu.edu, codalist@coda.cs.cmu.edu
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Xu Wang <vulab@iscas.ac.cn>
Subject: Re: [PATCH] upcall: Remove unneeded variable insize
Date: Mon, 17 Aug 2020 13:03:10 +0800	[thread overview]
Message-ID: <202008171257.63Jk4Pu2%lkp@intel.com> (raw)
In-Reply-To: <20200817025145.10009-1-vulab@iscas.ac.cn>

[-- Attachment #1: Type: text/plain, Size: 5225 bytes --]

Hi Xu,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.9-rc1 next-20200814]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Xu-Wang/upcall-Remove-unneeded-variable-insize/20200817-112244
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   fs/coda/upcall.c: In function 'venus_setattr':
   fs/coda/upcall.c:115:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
     115 |         union outputArgs *outp;
         |                           ^~~~
   fs/coda/upcall.c: In function 'venus_close':
   fs/coda/upcall.c:164:20: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
     164 |  union outputArgs *outp;
         |                    ^~~~
   fs/coda/upcall.c: In function 'venus_rename':
   fs/coda/upcall.c:238:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
     238 |         union outputArgs *outp;
         |                           ^~~~
   fs/coda/upcall.c: In function 'venus_rmdir':
   fs/coda/upcall.c:306:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
     306 |         union outputArgs *outp;
         |                           ^~~~
   fs/coda/upcall.c: In function 'venus_remove':
   fs/coda/upcall.c:329:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
     329 |         union outputArgs *outp;
         |                           ^~~~
   fs/coda/upcall.c: In function 'venus_link':
   fs/coda/upcall.c:383:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
     383 |         union outputArgs *outp;
         |                           ^~~~
   fs/coda/upcall.c: In function 'venus_symlink':
   fs/coda/upcall.c:410:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
     410 |         union outputArgs *outp;
         |                           ^~~~
   fs/coda/upcall.c: In function 'venus_fsync':
   fs/coda/upcall.c:443:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
     443 |         union outputArgs *outp;
         |                           ^~~~
   fs/coda/upcall.c: In function 'venus_access':
   fs/coda/upcall.c:459:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
     459 |         union outputArgs *outp;
         |                           ^~~~
   fs/coda/upcall.c: In function 'venus_pioctl':
>> fs/coda/upcall.c:63:44: error: 'insize' undeclared (first use in this function); did you mean 'iocsize'?
      63 |  inp = (union inputArgs *)alloc_upcall(op, insize); \
         |                                            ^~~~~~
   fs/coda/upcall.c:483:2: note: in expansion of macro 'UPARG'
     483 |  UPARG(CODA_IOCTL);
         |  ^~~~~
   fs/coda/upcall.c:63:44: note: each undeclared identifier is reported only once for each function it appears in
      63 |  inp = (union inputArgs *)alloc_upcall(op, insize); \
         |                                            ^~~~~~
   fs/coda/upcall.c:483:2: note: in expansion of macro 'UPARG'
     483 |  UPARG(CODA_IOCTL);
         |  ^~~~~
   fs/coda/upcall.c: In function 'venus_access_intent':
   fs/coda/upcall.c:576:20: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
     576 |  union outputArgs *outp;
         |                    ^~~~

# https://github.com/0day-ci/linux/commit/e126bb2bc1e15e86a4267e92df88f4987d01b358
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Xu-Wang/upcall-Remove-unneeded-variable-insize/20200817-112244
git checkout e126bb2bc1e15e86a4267e92df88f4987d01b358
vim +63 fs/coda/upcall.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  60  
^1da177e4c3f41 Linus Torvalds 2005-04-16  61  #define UPARG(op)\
^1da177e4c3f41 Linus Torvalds 2005-04-16  62  do {\
^1da177e4c3f41 Linus Torvalds 2005-04-16 @63  	inp = (union inputArgs *)alloc_upcall(op, insize); \
^1da177e4c3f41 Linus Torvalds 2005-04-16  64          if (IS_ERR(inp)) { return PTR_ERR(inp); }\
^1da177e4c3f41 Linus Torvalds 2005-04-16  65          outp = (union outputArgs *)(inp); \
^1da177e4c3f41 Linus Torvalds 2005-04-16  66          outsize = insize; \
^1da177e4c3f41 Linus Torvalds 2005-04-16  67  } while (0)
^1da177e4c3f41 Linus Torvalds 2005-04-16  68  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65068 bytes --]

  reply	other threads:[~2020-08-17  5:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-17  2:51 Xu Wang
2020-08-17  5:03 ` kernel test robot [this message]
2020-08-17  6:31 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202008171257.63Jk4Pu2%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=coda@cs.cmu.edu \
    --cc=codalist@coda.cs.cmu.edu \
    --cc=jaharkes@cs.cmu.edu \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®