From: Alex Dewar <alex.dewar90@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Alex Dewar <alex.dewar90@gmail.com>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] clang-format: Fix: Maximum line length is now 100
Date: Tue, 18 Aug 2020 17:53:59 +0100 [thread overview]
Message-ID: <20200818165359.jye5ch4uvdvkil36@medion> (raw)
In-Reply-To: <15980e07c369b2cbfc7b06f58f3a521a5495bdf6.camel@perches.com>
On Tue, Aug 18, 2020 at 09:52:20AM -0700, Joe Perches wrote:
> On Tue, 2020-08-18 at 17:24 +0100, Alex Dewar wrote:
> > Since commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column
> > warning") the kernel style is now for lines to be a maximum of 100 rather
> > than 80 columns. Update .clang-format accordingly.
> []
> > diff --git a/.clang-format b/.clang-format
> []
> > @@ -52,7 +52,7 @@ BreakConstructorInitializersBeforeComma: false
> > #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0
> > BreakAfterJavaFieldAnnotations: false
> > BreakStringLiterals: false
> > -ColumnLimit: 80
> > +ColumnLimit: 100
>
> No thank you.
>
> 100 is used for exceptional line length, not
> for reformatting all lines up to 100 chars.
>
> See the previous discussion about the same patch
> submitted earlier in June:
>
> https://lore.kernel.org/lkml/20200610125147.2782142-1-christian.brauner@ubuntu.com/
>
>
Ahh, my mistake. Thanks for getting back to me anyhoo.
Alex
prev parent reply other threads:[~2020-08-18 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 16:24 Alex Dewar
2020-08-18 16:52 ` Joe Perches
2020-08-18 16:53 ` Alex Dewar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818165359.jye5ch4uvdvkil36@medion \
--to=alex.dewar90@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®