From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B34CAC433DF for ; Wed, 19 Aug 2020 08:27:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87F22207DE for ; Wed, 19 Aug 2020 08:27:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597825675; bh=xkrOW1eiodxf6e55kbWanf+5qeDDwj1oob7ZKgc2bX4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Plz95goNSrTrPAx7xQ+RwpnPpz4bdsAv7Q5GCs3qZx+Oti/qp4vURcLis/8yQ0T40 zbvzogF5n1yaJrmWh24yskwjYII1NV8Yp0Q+Nz2+zjuN4F4EwhgrP+zLUqfxksCeFV 3OfIGHHNw20x4WYA6gRDrO0pYaizKwYIRT17wMqE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726750AbgHSI1y (ORCPT ); Wed, 19 Aug 2020 04:27:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:43338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725903AbgHSI1x (ORCPT ); Wed, 19 Aug 2020 04:27:53 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8306C20738; Wed, 19 Aug 2020 08:27:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597825673; bh=xkrOW1eiodxf6e55kbWanf+5qeDDwj1oob7ZKgc2bX4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fbutXiAaMlm/H9YbBaBayrJHz65E2rmbWgxqxuAdUYACLzGZK6lRujSRmkHg6MBoT jkPxKn2GE0mKyF++r7fCvlhIJSNDTQcpbUNxAFV9oO15FPtc09hhUgH/hTAm9Ueu5o xhq/e/O3Z4iYD7DK533RIYA+NrqZcpkxHyKy533M= Date: Wed, 19 Aug 2020 09:27:47 +0100 From: Will Deacon To: Linus Torvalds Cc: Yang Shi , Yu Xu , Johannes Weiner , Catalin Marinas , Will Deacon , Andrew Morton , Linux-MM , Linux Kernel Mailing List , stable Subject: Re: [v3 PATCH] mm/memory.c: skip spurious TLB flush for retried page fault Message-ID: <20200819082747.GA17345@willie-the-truck> References: <20200815043041.132195-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 18, 2020 at 12:01:43PM -0700, Linus Torvalds wrote: > On Mon, Aug 17, 2020 at 2:04 PM Yang Shi wrote: > > > > We could just skip the spurious TLB flush to mitigate the regression. > > Ok, this patch I will apply. Cheers. > I still hope that arm64 fixes (maybe already fixed) their spurious TLB > function, and I think we should rename it to make sure everybody > understands it's local, but in the meantime this patch hides the > regression and isn't wrong. I'll look at it for 5.10. Will