From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16508C433E1 for ; Wed, 19 Aug 2020 16:25:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D12D02067C for ; Wed, 19 Aug 2020 16:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597854356; bh=1GN23RM47/uiFPYCDNfEw1ChgK+WbXJt6mi9J1+KPZM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=St/rCS5yZRw13ylBl9HQMnB3BtheVV+R8/cFqej9jy7Z60Z4P++5dEem+QWMtXDWg dkUzVQnAW+QF67yKJzuO/cxY8IndDViTDSgaMnLRL0O2XC93Y02Y4DgWBMT1piSWJm qqsJ25F9TBDUQoCWJnPnU050kNgiZwqL/Isr1yoE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727870AbgHSQZ4 (ORCPT ); Wed, 19 Aug 2020 12:25:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:48898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726899AbgHSQZx (ORCPT ); Wed, 19 Aug 2020 12:25:53 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D100E2067C; Wed, 19 Aug 2020 16:25:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597854353; bh=1GN23RM47/uiFPYCDNfEw1ChgK+WbXJt6mi9J1+KPZM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SxfRbhaD6loD67guEjRdG/gEbK5t1IYqiheAx7Qiei6ixQTBNhlqM3EhHADw91Dqf pRhjWVgYopv3svG6+Cu1s2EDZ8sQjcPnYxnQQtIPaGdN2secPCEcV74u0Q+UXBFew2 NFB7WRaVPUh4P6iCqrGPrJ9ikZD+IcQFaSaYm4Yw= Date: Wed, 19 Aug 2020 09:25:51 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: Moshe Shemesh , Moshe Shemesh , "David S. Miller" , Jiri Pirko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command Message-ID: <20200819092551.6d94de03@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200819151815.GA2575@nanopsycho.orion> References: <1597657072-3130-1-git-send-email-moshe@mellanox.com> <1597657072-3130-2-git-send-email-moshe@mellanox.com> <20200817163612.GA2627@nanopsycho> <3ed1115e-8b44-b398-55f2-cee94ef426fd@nvidia.com> <20200818171010.11e4b615@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200819124616.GA2314@nanopsycho.orion> <20200819151815.GA2575@nanopsycho.orion> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Aug 2020 17:18:15 +0200 Jiri Pirko wrote: >>>> I will add counters on which reload were done. reload_down()/up() can return >>>> which actions were actually done and devlink will show counters. >>> Why a counter? Just return what was done over netlink reply. >> >> Such counters can be useful for debugging, telling which reload actions were >> done on this dev from the point it was up. > > Not sure why this is any different from other commands... Good question, perhaps because reset is more "dangerous"? The question of "what reset this NIC" does come up in practice. With live activation in the mix, knowing if the NIC FW was live activated will be very useful for dissecting failures, I'd imagine.