From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08336C433DF for ; Thu, 20 Aug 2020 00:14:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D04D02075E for ; Thu, 20 Aug 2020 00:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597882471; bh=iIGplnAK84nGuis37J0dVkTIxpYjbrSBgpmtpxAyPrk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yRRJ+olMT0YtsiZffChdnQRMnS5bL5DDwqycfozuqEp5vUDp4PGL3TRWEL1xcrQHx H/lxrwwdOjlK8zySwSiGKqtQg5AR8ZpjTGfm8W1LnHV7fENdx5lae6eWJtxLZF8JET +bXAyL6fVJukjWSDErhKNNe7PzwqGRdwLaION0Cw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726732AbgHTAOa (ORCPT ); Wed, 19 Aug 2020 20:14:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:57484 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726837AbgHTABY (ORCPT ); Wed, 19 Aug 2020 20:01:24 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB52D21741; Thu, 20 Aug 2020 00:01:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597881684; bh=iIGplnAK84nGuis37J0dVkTIxpYjbrSBgpmtpxAyPrk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zDjqRm2DLpjCFst6Z0N8SHJq/yoEatj+FqTcJB2C3MYCYuufc9Ymcy6hHMgNNr/zt VoEqROo1e31b7iRXSYj05XMjWZQOZ42vHsw3SR+pxfGvzl7/yxl3s/jZZbA8615ePx 2X4th5VilomnWuQsfZBtlWFfEXrERiSvX6+DCq+I= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chao Yu , Jaegeuk Kim , Sasha Levin , linux-f2fs-devel@lists.sourceforge.net Subject: [PATCH AUTOSEL 5.8 05/27] f2fs: fix to check page dirty status before writeback Date: Wed, 19 Aug 2020 20:00:54 -0400 Message-Id: <20200820000116.214821-5-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200820000116.214821-1-sashal@kernel.org> References: <20200820000116.214821-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chao Yu [ Upstream commit eb1353cfa9c1e9415b03dc117f8399969fa02102 ] In f2fs_write_raw_pages(), we need to check page dirty status before writeback, because there could be a racer (e.g. reclaimer) helps writebacking the dirty page. Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/compress.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c index 1e02a8c106b0a..ec4ffce4da8bf 100644 --- a/fs/f2fs/compress.c +++ b/fs/f2fs/compress.c @@ -1310,6 +1310,12 @@ static int f2fs_write_raw_pages(struct compress_ctx *cc, congestion_wait(BLK_RW_ASYNC, DEFAULT_IO_TIMEOUT); lock_page(cc->rpages[i]); + + if (!PageDirty(cc->rpages[i])) { + unlock_page(cc->rpages[i]); + continue; + } + clear_page_dirty_for_io(cc->rpages[i]); goto retry_write; } -- 2.25.1