From: kernel test robot <lkp@intel.com>
To: Martijn Coenen <maco@android.com>,
gregkh@linuxfoundation.org, tkjos@google.com, arve@android.com,
joel@joelfernandes.org, christian@brauner.io, hridya@google.com,
surenb@google.com
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
maco@google.com
Subject: Re: [PATCH] binder: print warnings when detecting oneway spamming.
Date: Thu, 20 Aug 2020 18:41:18 +0800 [thread overview]
Message-ID: <202008201814.TxGOq6Z2%lkp@intel.com> (raw)
In-Reply-To: <20200820075133.87040-1-maco@android.com>
[-- Attachment #1: Type: text/plain, Size: 3533 bytes --]
Hi Martijn,
I love your patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v5.9-rc1 next-20200820]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Martijn-Coenen/binder-print-warnings-when-detecting-oneway-spamming/20200820-155358
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git bc752d2f345bf55d71b3422a6a24890ea03168dc
config: s390-randconfig-r002-20200818 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 4deda57106f7c9b982a49cb907c33e3966c8de7f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install s390 cross compiling tool for clang build
# apt-get install binutils-s390x-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/android/binder_alloc_selftest.c:122:61: error: too few arguments to function call, expected 6, have 5
buffers[i] = binder_alloc_new_buf(alloc, sizes[i], 0, 0, 0);
~~~~~~~~~~~~~~~~~~~~ ^
drivers/android/binder_alloc.h:118:30: note: 'binder_alloc_new_buf' declared here
extern struct binder_buffer *binder_alloc_new_buf(struct binder_alloc *alloc,
^
1 error generated.
# https://github.com/0day-ci/linux/commit/9d0b269f4468d6793f6fd76a410fdde39dbf6ac2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Martijn-Coenen/binder-print-warnings-when-detecting-oneway-spamming/20200820-155358
git checkout 9d0b269f4468d6793f6fd76a410fdde39dbf6ac2
vim +122 drivers/android/binder_alloc_selftest.c
4175e2b46fd4b9 Sherry Yang 2017-08-23 114
4175e2b46fd4b9 Sherry Yang 2017-08-23 115 static void binder_selftest_alloc_buf(struct binder_alloc *alloc,
4175e2b46fd4b9 Sherry Yang 2017-08-23 116 struct binder_buffer *buffers[],
4175e2b46fd4b9 Sherry Yang 2017-08-23 117 size_t *sizes, int *seq)
4175e2b46fd4b9 Sherry Yang 2017-08-23 118 {
4175e2b46fd4b9 Sherry Yang 2017-08-23 119 int i;
4175e2b46fd4b9 Sherry Yang 2017-08-23 120
4175e2b46fd4b9 Sherry Yang 2017-08-23 121 for (i = 0; i < BUFFER_NUM; i++) {
4175e2b46fd4b9 Sherry Yang 2017-08-23 @122 buffers[i] = binder_alloc_new_buf(alloc, sizes[i], 0, 0, 0);
4175e2b46fd4b9 Sherry Yang 2017-08-23 123 if (IS_ERR(buffers[i]) ||
4175e2b46fd4b9 Sherry Yang 2017-08-23 124 !check_buffer_pages_allocated(alloc, buffers[i],
4175e2b46fd4b9 Sherry Yang 2017-08-23 125 sizes[i])) {
4175e2b46fd4b9 Sherry Yang 2017-08-23 126 pr_err_size_seq(sizes, seq);
4175e2b46fd4b9 Sherry Yang 2017-08-23 127 binder_selftest_failures++;
4175e2b46fd4b9 Sherry Yang 2017-08-23 128 }
4175e2b46fd4b9 Sherry Yang 2017-08-23 129 }
4175e2b46fd4b9 Sherry Yang 2017-08-23 130 }
4175e2b46fd4b9 Sherry Yang 2017-08-23 131
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 19968 bytes --]
next prev parent reply other threads:[~2020-08-20 10:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 7:51 Martijn Coenen
2020-08-20 10:41 ` kernel test robot [this message]
2020-08-20 11:47 ` Martijn Coenen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202008201814.TxGOq6Z2%lkp@intel.com \
--to=lkp@intel.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=clang-built-linux@googlegroups.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=maco@google.com \
--cc=surenb@google.com \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome