From: David Miller <davem@davemloft.net>
To: trix@redhat.com
Cc: f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: dsa: b53: check for timeout
Date: Fri, 21 Aug 2020 11:48:50 -0700 (PDT) [thread overview]
Message-ID: <20200821.114850.193253709080317487.davem@davemloft.net> (raw)
In-Reply-To: <20200821135600.18017-1-trix@redhat.com>
From: trix@redhat.com
Date: Fri, 21 Aug 2020 06:56:00 -0700
> From: Tom Rix <trix@redhat.com>
>
> clang static analysis reports this problem
>
> b53_common.c:1583:13: warning: The left expression of the compound
> assignment is an uninitialized value. The computed value will
> also be garbage
> ent.port &= ~BIT(port);
> ~~~~~~~~ ^
>
> ent is set by a successful call to b53_arl_read(). Unsuccessful
> calls are caught by an switch statement handling specific returns.
> b32_arl_read() calls b53_arl_op_wait() which fails with the
> unhandled -ETIMEDOUT.
>
> So add -ETIMEDOUT to the switch statement. Because
> b53_arl_op_wait() already prints out a message, do not add another
> one.
>
> Fixes: 1da6df85c6fb ("net: dsa: b53: Implement ARL add/del/dump operations")
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2020-08-21 18:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 13:56 trix
2020-08-21 14:43 ` Florian Fainelli
2020-08-21 18:48 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821.114850.193253709080317487.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=trix@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®