From: David Sterba <dsterba@suse.cz>
To: Tong Zhang <ztong0001@gmail.com>
Cc: jikos@kernel.org, dsterba@suse.com, gregkh@linuxfoundation.org,
jirislaby@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tty: ipwireless: fix error handling
Date: Fri, 21 Aug 2020 11:28:44 +0200 [thread overview]
Message-ID: <20200821092844.GB2026@suse.cz> (raw)
In-Reply-To: <20200818160401.4736-1-ztong0001@gmail.com>
On Tue, Aug 18, 2020 at 12:03:58PM -0400, Tong Zhang wrote:
> ipwireless_send_packet() can only return 0 on success and -ENOMEM on
> error, the caller should check non zero for error condition
Thanks.
Acked-by: David Sterba <dsterba@suse.com>
---
> v2: - According to Jiri's comment, I made the checking consistent with
> the rest of the kernel. I also rebased the code using f684668a24ec.
> Thank you Jiri!
---
This paragraph should not be in the changelog. The patches to ipwireless
go via Greg's tree, please send an updated v3 so he can just apply that
without further edits. Thanks.
next prev parent reply other threads:[~2020-08-21 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-16 7:43 [PATCH] " Tong Zhang
2020-08-18 8:35 ` Jiri Slaby
2020-08-18 16:03 ` [PATCH v2] " Tong Zhang
2020-08-21 9:28 ` David Sterba [this message]
2020-08-21 16:19 ` [PATCH v3] " Tong Zhang
2020-08-21 16:20 ` [PATCH v2] " Tong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821092844.GB2026@suse.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ztong0001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®