From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FF0EC433E1 for ; Fri, 21 Aug 2020 10:54:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60E2B20656 for ; Fri, 21 Aug 2020 10:54:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728560AbgHUKyF (ORCPT ); Fri, 21 Aug 2020 06:54:05 -0400 Received: from mga01.intel.com ([192.55.52.88]:2596 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728058AbgHUKwy (ORCPT ); Fri, 21 Aug 2020 06:52:54 -0400 IronPort-SDR: 8aNO/msoBSpTqqCklOoI2JacQjPjJQO7YCLjMr1I3OOZV3lZ1AUJ5pD9elmREgbCIopPhUm8HQ sEH1QZIVz28w== X-IronPort-AV: E=McAfee;i="6000,8403,9719"; a="173557967" X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="173557967" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2020 03:52:53 -0700 IronPort-SDR: O7Lz0ZnWt71v2rhcFMeN/ax6FCKFYVTkccb1vrG1j5ztBa9wkip6kUaRQ1nMEuIOPKHxS+3k0z lLexMjyeq4Ug== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="327731116" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 21 Aug 2020 03:52:50 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1k94fA-00AK5B-Ke; Fri, 21 Aug 2020 13:52:48 +0300 Date: Fri, 21 Aug 2020 13:52:48 +0300 From: Andy Shevchenko To: "Tanwar, Rahul" Cc: u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org, lee.jones@linaro.org, thierry.reding@gmail.com, p.zabel@pengutronix.de, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, songjun.Wu@intel.com, cheol.yong.kim@intel.com, qi-ming.wu@intel.com, rahul.tanwar.linux@gmail.com, rtanwar@maxlinear.com Subject: Re: [PATCH v8 2/2] Add PWM fan controller driver for LGM SoC Message-ID: <20200821105248.GM1891694@smile.fi.intel.com> References: <20200820105255.GB1891694@smile.fi.intel.com> <56c2a40d-6872-8ae7-7214-420b8bb9f027@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56c2a40d-6872-8ae7-7214-420b8bb9f027@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 21, 2020 at 05:14:29PM +0800, Tanwar, Rahul wrote: > On 20/8/2020 6:52 pm, Andy Shevchenko wrote: > > On Thu, Aug 20, 2020 at 12:50:46PM +0800, Rahul Tanwar wrote: > >> Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. > >> This PWM controller does not have any other consumer, it is a > >> dedicated PWM controller for fan attached to the system. Add > >> driver for this PWM fan controller. > > ... > > +#include > > +#include > > +#include > >> +#include > > This should be mod_devicetable.h. > > Inlcuding mod_devicetable.h instead of of_device.h results in > build failure related to all platform calls. Build is ok if > i remove it. Just FYI.. I didn't get what the change you performed, by there is no users of of_device.h in your code. If build fails it means you need to figure out proper list of what has to be included. -- With Best Regards, Andy Shevchenko